-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change VPA storage version from v1beta2 to v1 #3810
Conversation
@jbartosik @krzysied Could one of you review? |
I think this will also fix the failing e2e test - Admission-controller keeps limits unchanged when container controlled values is requests only (https://k8s-testgrid.appspot.com/sig-autoscaling-vpa#autoscaling-vpa-admission-controller). controlledValues is also missing from v1beta2 and thus dropped. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see any problems but I have a question.
How does one update an existing cluster (and preserve existing VPAs and checkpoints)?
When you apply the api changes, the api server will perform conversion of the stored objects whenever the object is read or written. Our conversion is a noop, since all the existing fields are the same between versions. This is true for both vpas and vpacheckpoints. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bskiba, jbartosik The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
With the recent switch to generated CRD definition, we also stopped saving unknown fields. Since v1beta2 does not contain some fields that v1 does, the fields get dropped silently on object creation.
Switching to v1 as storage version solves that problem.
fixes #3800