Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change VPA storage version from v1beta2 to v1 #3810

Merged
merged 2 commits into from
Jan 22, 2021

Conversation

bskiba
Copy link
Member

@bskiba bskiba commented Jan 12, 2021

With the recent switch to generated CRD definition, we also stopped saving unknown fields. Since v1beta2 does not contain some fields that v1 does, the fields get dropped silently on object creation.
Switching to v1 as storage version solves that problem.

fixes #3800

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 12, 2021
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 12, 2021
@bskiba
Copy link
Member Author

bskiba commented Jan 12, 2021

@jbartosik @krzysied Could one of you review?

@bskiba
Copy link
Member Author

bskiba commented Jan 12, 2021

I think this will also fix the failing e2e test - Admission-controller keeps limits unchanged when container controlled values is requests only (https://k8s-testgrid.appspot.com/sig-autoscaling-vpa#autoscaling-vpa-admission-controller).

controlledValues is also missing from v1beta2 and thus dropped.

Copy link
Collaborator

@jbartosik jbartosik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any problems but I have a question.

How does one update an existing cluster (and preserve existing VPAs and checkpoints)?

@bskiba
Copy link
Member Author

bskiba commented Jan 22, 2021

When you apply the api changes, the api server will perform conversion of the stored objects whenever the object is read or written. Our conversion is a noop, since all the existing fields are the same between versions. This is true for both vpas and vpacheckpoints.

Copy link
Collaborator

@jbartosik jbartosik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 22, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bskiba, jbartosik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 8aea4cd into kubernetes:master Jan 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[VPA] controlledResources field dropped from containerPolicy
3 participants