-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Follow WG Naming Recommendations on Master -> Control Plane #3803
Conversation
368f756
to
d390bd4
Compare
d390bd4
to
d872ec3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As many people may not be familiar what "control plane" node is (we have been using master
for ages), please add something like (previously known as "master node")
where applicable.
@mwielgus It feels a bit messy to me, but I've added clarifying text anywhere I moved from I've left anywhere that I changed from |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gjtempleton, mwielgus The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Updating documentation references to
master
to control plane/API Server as appropriate as per https://github.com/kubernetes/community/blob/master/wg-naming/recommendations/001-master-control-plane.mdA number of example files are renamed to match this convention.
I've left explicit references to the current
master
taint where discussed as part of allowing the CA to run on a control plane node as this is deprecated, but not yet removed as per: kubernetes/kubernetes#95382Fixes #3796