Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow WG Naming Recommendations on Master -> Control Plane #3803

Merged
merged 2 commits into from
Jan 22, 2021

Conversation

gjtempleton
Copy link
Member

Updating documentation references to master to control plane/API Server as appropriate as per https://github.com/kubernetes/community/blob/master/wg-naming/recommendations/001-master-control-plane.md

A number of example files are renamed to match this convention.

I've left explicit references to the current master taint where discussed as part of allowing the CA to run on a control plane node as this is deprecated, but not yet removed as per: kubernetes/kubernetes#95382

Fixes #3796

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 11, 2021
@k8s-ci-robot k8s-ci-robot requested review from d-mo and feiskyer January 11, 2021 22:42
Copy link
Contributor

@mwielgus mwielgus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As many people may not be familiar what "control plane" node is (we have been using master for ages), please add something like (previously known as "master node") where applicable.

@gjtempleton
Copy link
Member Author

gjtempleton commented Jan 19, 2021

@mwielgus It feels a bit messy to me, but I've added clarifying text anywhere I moved from master to control-plane along with some hidden TODO: stanzas to remind us to come back and remove these once k8s fully removes the terminology.

I've left anywhere that I changed from master to something more specific like API server as I feel that if they're unfamiliar with that terminology those terms should be easy enough to find more useful docs than previously.

Copy link
Contributor

@mwielgus mwielgus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 22, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gjtempleton, mwielgus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 22, 2021
@k8s-ci-robot k8s-ci-robot merged commit 7a786bc into kubernetes:master Jan 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update documentation to use “control plane” term
4 participants