Allow out-of-cluster operation of VPA #3769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because of how we operate our Kubernetes clusters, we need to run vertical pod autoscaler with an external kubeconfig. Also aligned and factored out redundant configuration code. Signed-off-by: Jens Erat <[email protected]>
Signed-off-by: Jens Erat <[email protected]>
Signed-off-by: Jens Erat <[email protected]>
k8s-ci-robot
added
cncf-cla: yes
|
/cc bskiba Thank you for your review some time ago, and sorry for the long delay. I had to recreate the PR, as |
|
/lgtm Apologies for the delay. |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bskiba, JensErat The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
This was referenced May 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because of how we operate our Kubernetes clusters, we need to run vertical pod autoscaler with an external kubeconfig. Also aligned and factored out redundant configuration code.
This is follow-up for now closed #2970. Regarding the open review comments:
Paths->Pathis fixed for both occurrencesvar limitRangeCalculator limitrange.LimitRangeCalculatorline (now vertical-pod-autoscaler/pkg/updater/main.go#86) can be removed, since it enforces the interface type. By removing this line, assigninglimitrange.NewNoopLimitsCalculator()in line 90 would fail.Jens Erat [email protected], Daimler TSS GmbH, imprint