-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[cluster-autoscaler] Backport fixes for packet provider to release-1.17 #3656
[cluster-autoscaler] Backport fixes for packet provider to release-1.17 #3656
Conversation
/assign @MaciekPytel |
/assign @displague |
The tests have failed with what seems like an unrelated error in Cluster API tests. At a glance it seems to be the same issue as #3597. @elmiko Can you take a look and possibly open cherry-pick PRs as you suggested in #3597 (comment)? I'm going to re-open to try and trigger a travis rerun. |
sure thing, i should be able to take a look today |
/lgtm |
Looks like the same test has failed again. I've already included cherry-picks of this in 1.19 and 1.18 patch releases, ideally it should also go into 1.17. I'd appreciate help fixing this, I'm happy to delay 1.17 release by a day or two if needed. |
@MaciekPytel i creaated this pr, #3662 looks like it shoud fix the issue
|
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: detiber, MaciekPytel The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
No description provided.