Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cluster-autoscaler] Backport fixes for packet provider to release-1.17 #3656

Conversation

detiber
Copy link
Member

@detiber detiber commented Oct 30, 2020

No description provided.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Oct 30, 2020
@detiber
Copy link
Member Author

detiber commented Oct 30, 2020

/assign @MaciekPytel

@detiber
Copy link
Member Author

detiber commented Oct 30, 2020

/assign @displague

@MaciekPytel
Copy link
Contributor

The tests have failed with what seems like an unrelated error in Cluster API tests. At a glance it seems to be the same issue as #3597. @elmiko Can you take a look and possibly open cherry-pick PRs as you suggested in #3597 (comment)?

I'm going to re-open to try and trigger a travis rerun.

@MaciekPytel MaciekPytel closed this Nov 2, 2020
@MaciekPytel MaciekPytel reopened this Nov 2, 2020
@elmiko
Copy link
Contributor

elmiko commented Nov 2, 2020

@elmiko Can you take a look and possibly open cherry-pick PRs as you suggested in #3597 (comment)?

sure thing, i should be able to take a look today

@displague
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 2, 2020
@MaciekPytel
Copy link
Contributor

Looks like the same test has failed again. I've already included cherry-picks of this in 1.19 and 1.18 patch releases, ideally it should also go into 1.17. I'd appreciate help fixing this, I'm happy to delay 1.17 release by a day or two if needed.

@elmiko
Copy link
Contributor

elmiko commented Nov 2, 2020

@MaciekPytel i creaated this pr, #3662

looks like it shoud fix the issue

$ stress ./clusterapi.test -test.run='TestControllerNodeGroups$' -test.cpu=8
106 runs so far, 0 failures
226 runs so far, 0 failures
324 runs so far, 0 failures

@MaciekPytel
Copy link
Contributor

Thanks for fixing it so quickly @elmiko.
I'm logging off now, I'll merge this PR tomorrow after #3662 is merged.

@MaciekPytel MaciekPytel closed this Nov 3, 2020
@MaciekPytel MaciekPytel reopened this Nov 3, 2020
@MaciekPytel
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: detiber, MaciekPytel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 3, 2020
@k8s-ci-robot k8s-ci-robot merged commit b435fcd into kubernetes:cluster-autoscaler-release-1.17 Nov 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants