Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only cap to limit in RequestOnly mode #3340

Merged
merged 1 commit into from
Jul 22, 2020
Merged

Only cap to limit in RequestOnly mode #3340

merged 1 commit into from
Jul 22, 2020

Conversation

bskiba
Copy link
Member

@bskiba bskiba commented Jul 21, 2020

No description provided.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 21, 2020
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 21, 2020
@bskiba
Copy link
Member Author

bskiba commented Jul 21, 2020

/assign @jbartosik
Joachim, would you be OK to review?

For context: RequestsOnly mode reintroduced the previous logic of treating limits - leave them alone and only cap request to limit. However, unintentionally, #3028 introduced capping to all VPA objects, including those that have limits proportional to requests. This broke e2e tests.
@johanneswuerbach FYI only, I think we're good with this fix.

@bskiba
Copy link
Member Author

bskiba commented Jul 21, 2020

Tests: https://k8s-testgrid.appspot.com/sig-autoscaling-vpa#autoscaling-vpa-admission-controller

@bskiba
Copy link
Member Author

bskiba commented Jul 21, 2020

I've run admission-controller tests with this change and they passed.

jbartosik
jbartosik approved these changes Jul 22, 2020
View reviewed changes
Copy link
Collaborator

@jbartosik jbartosik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 22, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jbartosik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 22, 2020
@k8s-ci-robot k8s-ci-robot merged commit ebbc578 into kubernetes:master Jul 22, 2020
@bskiba bskiba mentioned this pull request Jul 22, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbartosik jbartosik jbartosik approved these changes

@krzysied krzysied Awaiting requested review from krzysied

Assignees

@jbartosik jbartosik

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bskiba @k8s-ci-robot @jbartosik