Cherry-pick #3124: Allow small tolerance on memory capacity when comparing nodegroups

[DWSR]

No description provided.

[k8s-ci-robot]

Welcome @DWSR!

It looks like this is your first PR to kubernetes/autoscaler 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/autoscaler has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[DWSR]

/assign @piosz

[elmiko]

/lgtm

cc @JoelSpeed

[JoelSpeed]

Since this is in master, but no release-1.18 or release-1.17, I think we should be back porting this via those other branches as well, otherwise we will regress as people upgrade from the 1.16 release to later releases

[DWSR]

@JoelSpeed I agree. How would you like that to happen? Cherry pick from master to 1.18, from 1.18 to 1.17, etc.? Or should I simply open PRs for everything in parallel and let things become Eventually Consistent?

[JoelSpeed]

Cherry pick from master to 1.18, from 1.18 to 1.17, etc.?

That is the normal approach I believe yes, but I'd defer to someone like @MaciekPytel who is more involved with this project for the final say. Personally, I think there would be issue having them open in parallel, if the PR for an earlier release is merged before the PR for the later release this could become very confusing (if there's a delay for instance or a particular version drops of support and is decided that the cherry-pick should not merge etc)

[MaciekPytel]

I generally agree with @JoelSpeed. However, we're planning to do patch releases on all branches soon, so in the interest of making sure this gets to all branches in time I'm ok with opening cherry-picks in parallel. I'll make sure to merge them in the right order.

[DWSR]

I generally agree with @JoelSpeed. However, we're planning to do patch releases on all branches soon, so in the interest of making sure this gets to all branches in time I'm ok with opening cherry-picks in parallel. I'll make sure to merge them in the right order.

👍 I will open them all today

[nigelellis]

@DWSR thank you for porting this and starting the cherrypick process. I'm running EKS on 1.17 and also need this fix. @MaciekPytel, I checked the 1.17 cherry picks and didn't find this listed. Is there an approximate ETA on when this would get pulled in and when the next rollup release would be for 1.17? Thank you.

[nigelellis]

I found the cherry-pick issue that's tracking the 1.17 - tracked at #3317. Thanks.

[MaciekPytel]

Cherry-picks to 1.18 and 1.17 were merged, so there is no reason to block this anymore.
/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MaciekPytel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• cluster-autoscaler/OWNERS [MaciekPytel]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment