CA 1.18: Ensure VMSS is not under updating before scaling out #3025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
kind/bug
|
can you update the commit message and PR title to "Ensure VMSS is not under updating before scaling out" since that's the bigger part of the change |
feiskyer
changed the title
|
@marwanad Good catch. Updated and PTAL |
marwanad
reviewed
Apr 6, 2020
| klog.Errorf("VMSS %q is still under updating, waiting for it finishes before scaling", scaleSet.Name) | ||
| return fmt.Errorf("VMSS %q is still under updating", scaleSet.Name) | ||
| } | ||
|
|
||
| // Update the new capacity to cache. | ||
| vmssSizeMutex.Lock() | ||
| vmssInfo.Sku.Capacity = &size |
There was a problem hiding this comment.
update the provision state in cache here?
There was a problem hiding this comment.
weird, seems some changes have been lost with last commit. Fixed now.
caches after async PUT succeeds.
k8s-ci-robot
added
size/M
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: marwanad The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick #3023 and #3024 to CA 1.18:
/kind bug
/area provider/azure
/cc @nilo19 @marwanad