-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce VPA mutating webhook timeout from 30s to 10s #2969
Conversation
Welcome @dharmab! |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
84fca39
to
26c93c7
Compare
/assign @jbartosik |
/assign @bskiba |
A follow-up PR could make this timeout configurable, but reducing the timeout from the default 30s to the much saner 10s is an improvement and reflects the change in default between the admissionregistration.k8s.io/v1beta1 and admissionregistration.k8s.io/v1 types. |
@@ -75,6 +75,7 @@ func selfRegistration(clientset *kubernetes.Clientset, caCert []byte, namespace, | |||
RegisterClientConfig.URL = &url | |||
} | |||
sideEffects := v1beta1.SideEffectClassNone | |||
timeoutSeconds := int32(10) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we make it a flag?
I've decided to close this in favor of using #2949 instead. |
Fixes #2762