CAPI: Stop panicking in newMachineController #2940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
JoelSpeed
reviewed
Mar 18, 2020
Comment on lines
305
to
307
| if CAPIGroup == "" { | ||
| return nil, fmt.Errorf("could not get a CAPI group") | ||
| } |
There was a problem hiding this comment.
getCAPIGROUP can't return an empty string, so this check is redundant
There was a problem hiding this comment.
mm It does not hurt though, I guess it safe to assume it since getCAPIGROUP is well unit tested. Dropped it.
elmiko
reviewed
Mar 18, 2020
enxebre
force-pushed
the
set-resources-error
branch
from
d2b08f9 to
dfbb049
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/area provider/cluster-api |
k8s-ci-robot
added
the
area/provider/cluster-api
|
/lgtm |
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: elmiko The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
k8s-ci-robot
added a commit
that referenced
this pull request
Jun 2, 2020
[CA-1.18] #2940 cherry-pick CAPI: Stop panicking in newMachineController
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stop panicking in newMachineController