Add instructions to tag resource for scale from 0 case #2929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
Jeffwan
force-pushed
the
add_resource_doc
branch
from
7b34f32 to
33c70ee
Compare
xinxingliu90
approved these changes
Mar 13, 2020
|
@Jeffwan Thank you for adding this guidance, this is helpful for our team! |
jaypipes
suggested changes
Mar 26, 2020
Jeffwan
force-pushed
the
add_resource_doc
branch
2 times, most recently
from
bf3da33 to
b2f792f
Compare
Jeffwan
force-pushed
the
add_resource_doc
branch
from
b2f792f to
f7f50d9
Compare
|
@jaypipes Address the feedbacks and fix typos. :D |
|
/lgtm Thank you @Jeffwan! |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jaypipes The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
This was referenced Mar 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have the feature but lack of docs. Add some instructions to make it clear for scale from 0 case.
Address issue. #2927 #2888