Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use ioutil for certificate file reading. #2186

Merged
merged 1 commit into from
Jul 17, 2019
Merged

Use ioutil for certificate file reading. #2186

merged 1 commit into from
Jul 17, 2019

Conversation

jackkleeman
Copy link
Contributor

Currently we read certificate files into a buffer of 5000 bytes. This sets a max size for our certificates; above this max, we will get invalid certs, most likely, leading to runtime bad certificate errors.

@k8s-ci-robot
Copy link
Contributor

Welcome @jackkleeman!

It looks like this is your first PR to kubernetes/autoscaler 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/autoscaler has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 11, 2019
@jackkleeman
Copy link
Contributor Author

/assign @jbartosik

@bskiba bskiba assigned bskiba and unassigned jbartosik Jul 16, 2019
bskiba
bskiba approved these changes Jul 16, 2019
View reviewed changes
Copy link
Member

@bskiba bskiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! The change LGTM, I left two comments that you can ignore, since these are not directly connected to this change but it would be nice to have them while you're at it :)

@jackkleeman
Use ioutil for certificate file reading.
4c9fe1b 
Currently we read certificate files into a buffer of 5000 bytes. This
sets a max size for our certificates; above this max, we will get
invalid certs, most likely, leading to runtime bad certificate errors.
@jackkleeman
Copy link
Contributor Author

Done @bskiba :)

@jackkleeman
Copy link
Contributor Author

/assign @bskiba

@bskiba
Copy link
Member

bskiba commented Jul 17, 2019

Thanks!
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 17, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bskiba

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 17, 2019
@k8s-ci-robot k8s-ci-robot merged commit 969337e into kubernetes:master Jul 17, 2019
@jackkleeman jackkleeman deleted the cert-file-read branch July 18, 2019 23:05
@danielmellado danielmellado mentioned this pull request Oct 24, 2019
Closed
@jackkleeman jackkleeman mentioned this pull request Nov 12, 2019
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bskiba bskiba bskiba approved these changes

@jbartosik jbartosik Awaiting requested review from jbartosik

@mwielgus mwielgus Awaiting requested review from mwielgus

Assignees

@bskiba bskiba

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jackkleeman @k8s-ci-robot @bskiba @jbartosik