Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add m5ad, r5ad and t3a instance families #1970

Merged
merged 1 commit into from
Apr 29, 2019

Conversation

Jeffwan
Copy link
Contributor

@Jeffwan Jeffwan commented Apr 29, 2019

Add m5ad, r5ad and t3a instance families. Address #1936

Will take some time later to find a way to dynamically load latest instance in runtime. This is not elegant that every time we need to add new instance types

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 29, 2019
@k8s-ci-robot k8s-ci-robot requested review from losipiuk and piosz April 29, 2019 05:06
@bskiba bskiba added area/provider/aws Issues or PRs related to aws provider area/cluster-autoscaler labels Apr 29, 2019
@bskiba
Copy link
Member

bskiba commented Apr 29, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 29, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bskiba

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 29, 2019
@k8s-ci-robot k8s-ci-robot merged commit d9a8661 into kubernetes:master Apr 29, 2019
@Jeffwan Jeffwan deleted the add_new_instance_type branch April 29, 2019 18:35
@sc250024
Copy link
Contributor

When is this getting released? Currently none of the latest CA releases support the new t3a instances types.

@Jeffwan
Copy link
Contributor Author

Jeffwan commented Jun 23, 2019

@sc250024 This is included in 1.15 branch. Do you need t3a instance in older branches? I can cherry-pick back to other branches as well

@sc250024
Copy link
Contributor

sc250024 commented Jun 23, 2019

@Jeffwan Thanks for your reply, my comment above sounded a bit bitchy, sorry for that 😅

Anyway, if you could cherry pick the changes into the 1.13 and 1.14 branches, that would be very much desired. Case in point, the latest version of EKS on AWS only supports up to 1.13 at the latest, with 1.14 coming soon.

Thank you sir!

@Jeffwan
Copy link
Contributor Author

Jeffwan commented Jun 24, 2019

Sure. I will cherry-pick the change back to 1.12-1.14. BTW, this won't release immediately, release team has it's schedule.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cluster-autoscaler area/provider/aws Issues or PRs related to aws provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants