Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vertical Pod Autoscaler version 0.3.0 #1373

Merged
merged 1 commit into from
Nov 2, 2018

Conversation

bskiba
Copy link
Member

@bskiba bskiba commented Nov 2, 2018

No description provided.

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 2, 2018
@bskiba
Copy link
Member Author

bskiba commented Nov 2, 2018

@kgolab @schylek @mwielgus

@mwielgus
Copy link
Contributor

mwielgus commented Nov 2, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 2, 2018
@mwielgus
Copy link
Contributor

mwielgus commented Nov 2, 2018

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mwielgus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 2, 2018
@k8s-ci-robot k8s-ci-robot merged commit 81c2888 into kubernetes:master Nov 2, 2018
yaroslava-serdiuk pushed a commit to yaroslava-serdiuk/autoscaler that referenced this pull request Feb 22, 2024
* Add StopReason argument for the Stop method of the
  JobWithCustomStop interface.

* Change Stop method for the pod controller to delete
  even suspended pods if workload is being deleted.

* Change pods in group finalization for the case of workload
  deletion. Now all pods in the group will be finalized
  right after the pod group has been stopped.

* Add new unit tests for the pod controller and webhook.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants