Cherry-pick of #1168: Ignore resources with Cloud TPU prefix #1177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
size/M
|
/lgtm |
k8s-ci-robot
added
the
lgtm
aleksandra-malinowska
merged commit 2916f3d
into
kubernetes:cluster-autoscaler-release-1.2
yaroslava-serdiuk
pushed a commit
to yaroslava-serdiuk/autoscaler
that referenced
this pull request
Feb 22, 2024
* Fix job finalization logic in generic reconciler * In the case of a finished job, it should be finalized before updating the Workload status, because if any errors are occurring during finalization, it will never be reached by reconciler again if workload has a 'Finished' condition. * Add test case for pod integration, change old test * Add a test case validating that 'Finished' workload status condition is added even if the pod is finalized. Which could happen due to client error while updating wl conditions. * Simplify 'TestReconciler_ErrorFinalizingPod'. * Fix pod_controller_test.go for go race detector * Replace Pod mock with the client interceptor func
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #1168: Ignore resources with Cloud TPU prefix