Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cluster Autoscaler 1.2.3-beta.1 #1147

Merged
merged 1 commit into from
Aug 14, 2018
Merged

Cluster Autoscaler 1.2.3-beta.1 #1147

merged 1 commit into from
Aug 14, 2018

Conversation

aleksandra-malinowska
Copy link
Contributor

Update Cluster Autoscaler version to 1.2.3-beta.1

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 14, 2018
@MaciekPytel
Copy link
Contributor

/lgtm
Although I'm not sure how are we planning to test this beta. In the past we usually only did a manual test of changes included in patch release. After changing godeps we really should run all e2e tests. That being said as 1.10 patch release manager I don't feel too happy about cherry-picking beta version just to run e2e on it.

Same applies to #1146.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 14, 2018
@aleksandra-malinowska aleksandra-malinowska merged commit 45ead13 into kubernetes:cluster-autoscaler-release-1.2 Aug 14, 2018
@aleksandra-malinowska
Copy link
Contributor Author

Good point about testing - we've never committed a beta version to a release branch before. I wonder if we could override the image just for e2e tests (at least on GCE)?

yaroslava-serdiuk pushed a commit to yaroslava-serdiuk/autoscaler that referenced this pull request Feb 22, 2024
@mwielgus
KEP-1136 ProvisioningRequest support (kubernetes#1147)
d099039
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feiskyer feiskyer Awaiting requested review from feiskyer

@MaciekPytel MaciekPytel Awaiting requested review from MaciekPytel

Assignees

@MaciekPytel MaciekPytel

Labels
area/cluster-autoscaler cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aleksandra-malinowska @MaciekPytel @k8s-ci-robot