Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use EC2 DescribeInstanceTypes API instead of parsing pricing API #4436

Closed
AustinSiu opened this issue Nov 1, 2021 · 8 comments
Closed

Use EC2 DescribeInstanceTypes API instead of parsing pricing API #4436

AustinSiu opened this issue Nov 1, 2021 · 8 comments
Labels
area/cluster-autoscaler area/provider/aws Issues or PRs related to aws provider kind/feature Categorizes issue or PR as related to a new feature. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.

Comments

@AustinSiu
Copy link
Contributor

Which component are you using?:
Cluster Autoscaler

Is your feature request designed to solve a problem? If so describe the problem this feature should solve.:

CA maintains code to handle instance filtering and parsing from EC2 pricing API.

Describe the solution you'd like.:

Update existing API call with a filterable list through EC2's DescribeInstanceTypes API to simplify the logic.

Describe any alternative solutions you've considered.:

Additional context.:

@AustinSiu AustinSiu added the kind/feature Categorizes issue or PR as related to a new feature. label Nov 1, 2021
@gjtempleton
Copy link
Member

/area provider/aws

@k8s-ci-robot k8s-ci-robot added the area/provider/aws Issues or PRs related to aws provider label Nov 5, 2021
@sbs2001
Copy link
Member

sbs2001 commented Nov 5, 2021

@AustinSiu are you working on a patch for this ? If not I'd like to submit one :)

@AustinSiu
Copy link
Contributor Author

AustinSiu commented Nov 5, 2021

@AustinSiu are you working on a patch for this ? If not I'd like to submit one :)

@sbs2001 I'm actively working on a patch for this. Thanks for checking!

@jaypipes
Copy link
Contributor

jaypipes commented Dec 6, 2021

@gjtempleton honestly, I don't know why we didn't go this route when the EC2 DescribeInstanceTypes API was released in November 22, 2019. I'm supportive of this approach and @AustinSiu's PR looks solid to me.

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 6, 2022
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Apr 5, 2022
@gjtempleton
Copy link
Member

Addressed by #4468 which has now been merged and released.
/close

@k8s-ci-robot
Copy link
Contributor

@gjtempleton: Closing this issue.

In response to this:

Addressed by #4468 which has now been merged and released.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cluster-autoscaler area/provider/aws Issues or PRs related to aws provider kind/feature Categorizes issue or PR as related to a new feature. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
None yet
Development

No branches or pull requests

7 participants