-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use EC2 DescribeInstanceTypes API instead of parsing pricing API #4436
Comments
/area provider/aws |
@AustinSiu are you working on a patch for this ? If not I'd like to submit one :) |
@sbs2001 I'm actively working on a patch for this. Thanks for checking! |
@gjtempleton honestly, I don't know why we didn't go this route when the EC2 DescribeInstanceTypes API was released in November 22, 2019. I'm supportive of this approach and @AustinSiu's PR looks solid to me. |
The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle rotten |
Addressed by #4468 which has now been merged and released. |
@gjtempleton: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Which component are you using?:
Cluster Autoscaler
Is your feature request designed to solve a problem? If so describe the problem this feature should solve.:
CA maintains code to handle instance filtering and parsing from EC2 pricing API.
Describe the solution you'd like.:
Update existing API call with a filterable list through EC2's DescribeInstanceTypes API to simplify the logic.
Describe any alternative solutions you've considered.:
Additional context.:
The text was updated successfully, but these errors were encountered: