-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CAPI: Automation for deepcopy and audit internal types #3011
Comments
/area provider/cluster-api |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
/remove-lifecycle stale |
Can we close this since we merged #3312 ? |
certainly seems like we can to me. plus, we can always re-open if need be ;) |
@elmiko: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Currently the deepcopy code for the internal CAPI types i.e machineSet and machineDeployment is harcoded here https://github.com/kubernetes/autoscaler/blob/master/cluster-autoscaler/cloudprovider/clusterapi/zz_generated.deepcopy.go.
We need to:
-Provide automation to generate the script.
-Auditing. For this there are two options:
1- Mirror the CAPI types into our internal types and fuzzy test round trips API server->unstructure->internal type -> unstructure.
2- Drop any field from the internal types which is not needed/supported in the autoscaler provider, gate on it and unit test those. This won't hide any issue for a developer trying to leverage a new field of the public CAPI types as this wouldn't exist in the internal types, therefore preventing golang from compiling.
The text was updated successfully, but these errors were encountered: