Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CAPI: Automation for deepcopy and audit internal types #3011

Closed
enxebre opened this issue Apr 1, 2020 · 7 comments
Closed

CAPI: Automation for deepcopy and audit internal types #3011

enxebre opened this issue Apr 1, 2020 · 7 comments
Labels
area/provider/cluster-api Issues or PRs related to Cluster API provider

Comments

@enxebre
Copy link
Member

enxebre commented Apr 1, 2020

Currently the deepcopy code for the internal CAPI types i.e machineSet and machineDeployment is harcoded here https://github.com/kubernetes/autoscaler/blob/master/cluster-autoscaler/cloudprovider/clusterapi/zz_generated.deepcopy.go.
We need to:
-Provide automation to generate the script.

-Auditing. For this there are two options:
1- Mirror the CAPI types into our internal types and fuzzy test round trips API server->unstructure->internal type -> unstructure.

2- Drop any field from the internal types which is not needed/supported in the autoscaler provider, gate on it and unit test those. This won't hide any issue for a developer trying to leverage a new field of the public CAPI types as this wouldn't exist in the internal types, therefore preventing golang from compiling.

@enxebre
Copy link
Member Author

enxebre commented Apr 1, 2020

/area provider/cluster-api

@k8s-ci-robot k8s-ci-robot added the area/provider/cluster-api Issues or PRs related to Cluster API provider label Apr 1, 2020
@enxebre
Copy link
Member Author

enxebre commented Apr 1, 2020

cc @JoelSpeed @elmiko

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 30, 2020
@enxebre
Copy link
Member Author

enxebre commented Jun 30, 2020

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 30, 2020
@benmoss
Copy link
Member

benmoss commented Aug 25, 2020

Can we close this since we merged #3312 ?

@elmiko
Copy link
Contributor

elmiko commented Aug 25, 2020

certainly seems like we can to me.

plus, we can always re-open if need be ;)
/close

@k8s-ci-robot
Copy link
Contributor

@elmiko: Closing this issue.

In response to this:

certainly seems like we can to me.

plus, we can always re-open if need be ;)
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/provider/cluster-api Issues or PRs related to Cluster API provider
Projects
None yet
Development

No branches or pull requests

5 participants