Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Behavior wrt min/max limits is not publicly documented #1849

Closed
Shnatsel opened this issue Apr 2, 2019 · 3 comments
Closed

Behavior wrt min/max limits is not publicly documented #1849

Shnatsel opened this issue Apr 2, 2019 · 3 comments

Comments

@Shnatsel
Copy link
Contributor

Shnatsel commented Apr 2, 2019

Cluster autoscaler FAQ does not describe how CA handles min/max limits.

People often expect min/max to be enforced by CA, and that changing the minimum number of nodes alone will trigger a scale-up (example). The actual behavior is that CA does not enforce these limits, so if someone manually resizes the cluster beyond those limits, CA will not intervene.

Since this is a common cause of misunderstanding, we need some public documentation on the expected behavior.

@MaciekPytel
Copy link
Contributor

You're 100% right, this should be documented. Do you want to take a shot at writing it up?

@Shnatsel
Copy link
Contributor Author

Shnatsel commented Apr 2, 2019

Sure. I'll open a PR to get the ball rolling, and check "allow edits from maintainers" so that you can correct anything I got wrong.

@Jeffwan
Copy link
Contributor

Jeffwan commented Apr 2, 2019

I have an issue related here. #1559

Auto-Discovery is preferred and min/max does brings confusion. I didn't come up good solutions on code side, documentation will be helpful.

Shnatsel added a commit to Shnatsel/autoscaler that referenced this issue Apr 4, 2019
Initial documentation for the handling of min_nodes and max_nodes parameters. These are currently not publicly documented and have caused some confusion.

Fixes kubernetes#1849
tim-smart pushed a commit to arisechurch/autoscaler that referenced this issue Nov 22, 2022
Initial documentation for the handling of min_nodes and max_nodes parameters. These are currently not publicly documented and have caused some confusion.

Fixes kubernetes#1849
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants