Skip to content

Commit

Permalink
Move DisableScaleDownForLoop to the scaleUp loop
Browse files Browse the repository at this point in the history
When running the autoscaler with `--max-nodes-total` set and that max is reached downscale is disabled when new unschedulable pods are added.
Preventing the removal of nodes.
If pods are created very frequently by let's say a cronjob, the cluster will never be able to downscale.
In order to fix that behavior i moved the downscale lock from the process to the actual place where scale-up happens.
  • Loading branch information
nyodas committed Sep 30, 2020
1 parent 4679102 commit e87be3e
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion cluster-autoscaler/core/filter_out_schedulable.go
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,6 @@ func (p *filterOutSchedulablePodListProcessor) Process(

if len(unschedulablePodsToHelp) != len(unschedulablePods) {
klog.V(2).Info("Schedulable pods present")
context.ProcessorCallbacks.DisableScaleDownForLoop()
} else {
klog.V(4).Info("No schedulable pods")
}
Expand Down

0 comments on commit e87be3e

Please sign in to comment.