Use caching when getting controllers

kubernetes · Oct 8, 2020 · 8711a1e · 8711a1e
1 parent 0f669ca
commit 8711a1e
Showing 1 changed file with 12 additions and 2 deletions.
diff --git a/vertical-pod-autoscaler/pkg/recommender/input/cluster_feeder.go b/vertical-pod-autoscaler/pkg/recommender/input/cluster_feeder.go
@@ -49,7 +49,14 @@ import (
 	resourceclient "k8s.io/metrics/pkg/client/clientset/versioned/typed/metrics/v1beta1"
 )
 
-const defaultResyncPeriod time.Duration = 10 * time.Minute
+const (
+	betweenContainerParentRefreshes     time.Duration = 10 * time.Minute
+	containerCacheCleanupLoopPeriod     time.Duration = time.Hour
+	containerCacheRefreshLoopPeriod     time.Duration = time.Minute
+	containerParentRefreshCacheLifetime time.Duration = time.Hour
+	containerParentRefreshJitter        time.Duration = time.Minute
+	defaultResyncPeriod                 time.Duration = 10 * time.Minute
+)
 
 // ClusterStateFeeder can update state of ClusterState object.
 type ClusterStateFeeder interface {
@@ -109,7 +116,10 @@ func NewClusterStateFeeder(config *rest.Config, clusterState *model.ClusterState
 	podLister, oomObserver := NewPodListerAndOOMObserver(kubeClient, namespace)
 	factory := informers.NewSharedInformerFactoryWithOptions(kubeClient, defaultResyncPeriod, informers.WithNamespace(namespace))
 	dirtectControllerParentGetter := controllerfetcher.NewDirectControllerParentGetter(config, kubeClient, factory)
-	controllerFetcher := controllerfetcher.NewControllerFetcher(dirtectControllerParentGetter)
+	cachingControllerParentGetter := controllerfetcher.NewCachingControllerGetter(betweenContainerParentRefreshes, containerParentRefreshJitter, containerParentRefreshCacheLifetime, dirtectControllerParentGetter)
+	cachingControllerParentGetter.Start(context.TODO(), containerCacheCleanupLoopPeriod, containerCacheRefreshLoopPeriod)
+	controllerFetcher := controllerfetcher.NewControllerFetcher(cachingControllerParentGetter)
+
 	return ClusterStateFeederFactory{
 		PodLister:           podLister,
 		OOMObserver:         oomObserver,