Merge pull request #6528 from yarinm/yarinm/expectedToRegister-fix

Fix expectedToRegister to respect instances with nil status
kubernetes · Feb 22, 2024 · 6ca8414 · 6ca8414
2 parents a3c8978 + 7128cb7
commit 6ca8414
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/cluster-autoscaler/clusterstate/clusterstate.go b/cluster-autoscaler/clusterstate/clusterstate.go
@@ -1033,7 +1033,7 @@ func getNotRegisteredNodes(allNodes []*apiv1.Node, cloudProviderNodeInstances ma
 }
 
 func expectedToRegister(instance cloudprovider.Instance) bool {
-	return instance.Status != nil && instance.Status.State != cloudprovider.InstanceDeleting && instance.Status.ErrorInfo == nil
+	return instance.Status == nil || (instance.Status.State != cloudprovider.InstanceDeleting && instance.Status.ErrorInfo == nil)
 }
 
 // Calculates which of the registered nodes in Kubernetes that do not exist in cloud provider.