Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for timeout spawning sub process and needs vars exported #179

Merged

Conversation

jsturtevant
Copy link
Contributor

Fixes timeout on control nodes introduced with #178

Timeout cmd spawns sub process and needs vars exported otherwise end up with error message during provisioning becuase KUBECTL varaible is missing

bash: line 1: get: command not found
bash: line 4: get: command not found
node/k8s-master-12396028-0 tainted
node/k8s-master-12396028-0 labeled
daemonset.apps/prepull created
daemonset.apps "prepull" deleted

which results in errors like:

 Jul  8 08:21:43.397: FAIL: Error waiting for all pods to be running and ready: 2 / 10 pods in namespace "kube-system" are NOT in RUNNING and READY state in 10m0s
Jul  8 00:34:49.082: INFO: >>> kubeConfig: /root/tmp013712723/kubeconfig/kubeconfig.eastus2.json
Jul  8 00:34:49.104: INFO: Waiting up to 30m0s for all (but 0) nodes to be schedulable
Jul  8 00:34:49.358: FAIL: Unexpected error:
    <*errors.errorString | 0xc002f2a7d0>: {
        s: "there are currently no ready, schedulable nodes in the cluster",
    }
    there are currently no ready, schedulable nodes in the cluster 

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 8, 2020
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 8, 2020
@jsturtevant
Copy link
Contributor Author

/assign @chewong

Copy link
Member

@chewong chewong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 8, 2020
@chewong
Copy link
Member

chewong commented Jul 8, 2020

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chewong, jsturtevant

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 8, 2020
@k8s-ci-robot k8s-ci-robot merged commit 3669b6a into kubernetes-sigs:master Jul 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants