-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(chart): allow gmsa to be made more HA #87
Conversation
Welcome @acobaugh! |
1b803ed
to
b20cb5d
Compare
/lgtm Thanks! |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: acobaugh, marosset The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This PR allows gmsa to be made more HA when installed via the chart. Since the webhook prevents pod creation at the k8s API level, it's critical that gmsa is able to be made more HA.
nodeSelector
instead ofpodAffinity
to place pods on linux nodes, to allow consumers of the chart greater freedom when settingaffinity
replicaCount
PodDisruptionBudget
affinity
to allow further pod placement customization