Updating helm charts to set OS field on Pod specs for applicable K8s versions

[marosset]

Signed-off-by: Mark Rossetti [email protected]

[marosset]

/assign @jsturtevant @phillipsj
/cc @ravisantoshgudimetla

[jsturtevant]

/lgtm

[jsturtevant]

taking another look, do we want to add this field to https://github.com/kubernetes-sigs/windows-gmsa/blob/master/admission-webhook/deploy/gmsa-webhook.yml.tpl for the non chart yaml files? At some point, We should probably update the script to generate the templates with that instead of maintaining to versions

[marosset]

taking another look, do we want to add this field to https://github.com/kubernetes-sigs/windows-gmsa/blob/master/admission-webhook/deploy/gmsa-webhook.yml.tpl for the non chart yaml files? At some point, We should probably update the script to generate the templates with that instead of maintaining to versions

I thought about this and didn't have a good way of conditionally applying the OS field on depending on the K8s version.
If we want I can try doing something in another PR but I'm not sure if there is a big benefit in doing that.

[phillipsj]

I think we could generate the templates from the helm chart and account for k8s version. Now that I’m doing a lot more chart work, I can see if I can get a draft up for it

…

On Wed, Jul 20, 2022 at 6:55 PM Mark Rossetti ***@***.***> wrote: taking another look, do we want to add this field to https://github.com/kubernetes-sigs/windows-gmsa/blob/master/admission-webhook/deploy/gmsa-webhook.yml.tpl for the non chart yaml files? At some point, We should probably update the script to generate the templates with that instead of maintaining to versions I thought about this and didn't have a good way of conditionally applying the OS field on depending on the K8s version. If we want I can try doing something in another PR but I'm not sure if there is a big benefit in doing that. — Reply to this email directly, view it on GitHub <#81 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAL63BPD2HZPUVPJWMR4GEDVVB7VTANCNFSM54BJCIOQ> . You are receiving this because you were assigned.Message ID: ***@***.***>

[jsturtevant]

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsturtevant, marosset

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [jsturtevant,marosset]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment