Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding the ability to configure the webhook port. #57

Merged
merged 1 commit into from
Feb 15, 2022
Merged

Adding the ability to configure the webhook port. #57

merged 1 commit into from
Feb 15, 2022

Conversation

phillipsj
Copy link
Contributor

@phillipsj phillipsj commented Feb 11, 2022 •
edited
Loading

Adding the ability to configure the webhook port by setting an environment variable called HTTPS_PORT. If not set, it will default to 443, the current default port.

Signed-off-by: Jamie Phillips [email protected]

@phillipsj
Adding the ability to configure the webhook port.
e366f8e 
Adding the ability to configure the webhook port by setting an environment variable called HTTPS_PORT. If not set, it will default to 443, the current default port.

Signed-off-by: Jamie Phillips <[email protected]>
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 11, 2022
@k8s-ci-robot k8s-ci-robot requested review from marosset and wk8 February 11, 2022 03:39
@phillipsj
Copy link
Contributor Author

/assign @jsturtevant

@marosset
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Feb 11, 2022
marosset
marosset approved these changes Feb 15, 2022
View reviewed changes
Copy link
Contributor

@marosset marosset left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

It would be nice to document this somewhere other than the code but the project doesn't have a good place to add this :(

Let's make at least expose this new env var in the helm charts added by #55

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: marosset, phillipsj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 15, 2022
@k8s-ci-robot k8s-ci-robot merged commit 7efead1 into kubernetes-sigs:master Feb 15, 2022
@phillipsj
Copy link
Contributor Author

@marosset yes, that is the plan to expose that in the chart. I will be getting that one squared away this week.

@jsturtevant jsturtevant mentioned this pull request Feb 16, 2022
Closed
@phillipsj phillipsj mentioned this pull request Feb 28, 2022
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marosset marosset marosset approved these changes

@wk8 wk8 Awaiting requested review from wk8

Assignees

@jsturtevant jsturtevant

@marosset marosset

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@phillipsj @marosset @k8s-ci-robot @jsturtevant