Adding v1 version for gmsacredentialspec CRDs

[marosset]

Signed-off-by: Mark Rossetti [email protected]

Fixes #43

I ran our 'GMSA Full' test on a local cluster and got passing results.
I even saw the deprecation message saying to use the v1 api

Aug 12 13:40:47.914: INFO: stdout: "apiVersion: windows.k8s.io/v1alpha1\r\nkind: GMSACredentialSpec\r\nmetadata:\r\n  name: gmsa-e2e\r\ncredspec:\r\n  CmsPlugins:\r\n  - ActiveDirectory\r\n  DomainJoinConfig:\r\n    Sid: S-1-5-21-1709982657-1049071122-2546699011\r\n    MachineAccountName: gmsa-e2e\r\n    Guid: d6473599-ce06-46e0-9fa4-ee965441c629\r\n    DnsTreeName: k8sgmsa.lan\r\n    DnsName: k8sgmsa.lan\r\n    NetBiosName: k8sgmsa\r\n  ActiveDirectoryConfig:\r\n    GroupManagedServiceAccounts:\r\n    - Name: gmsa-e2e\r\n      Scope: k8sgmsa.lan\r\n    - Name: gmsa-e2e\r\n      Scope: k8sgmsa\r\n\r\n"

<snip>

Aug 12 13:40:57.120: INFO: stderr: "Warning: windows.k8s.io/v1alpha1 GMSACredentialSpec is deprecated; use windows.k8s.io/v1 GMSACredentialSpec\n"

<snip>

"msg":"PASSED [sig-windows] [Feature:Windows] GMSA Full [Serial] [Slow] GMSA support works end to end","total":1,"completed":1,"skipped":5604,"failed":0}
SSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSS

[jsturtevant]

Do you think we can add an integration test to the suite that shows we can grab both versions or something along those lines?

[marosset]

Do you think we can add an integration test to the suite that shows we can grab both versions or something along those lines?

Yea, let me look into that.

[marosset]

/retest

[marosset]

@jsturtevant I finally had a chance to add some integration tests that verify you can query either v1alpha1 or v1 CRD versions.

[jsturtevant]

thanks for adding tests, one comment about the test specs

[jsturtevant]

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsturtevant, marosset

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [jsturtevant,marosset]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[jsturtevant]

/sig windows