Update ENV variable name in syncer to match with the deployment yaml file

[chethanv28]

What this PR does / why we need it:
This PR will fix the ENV variable name for FULL SYNC interval in syncer source files to match with the ENV specified in the deployment file
We need this change for users to customize the full sync interval and for this the ENV variables in the source code must match with the deployment yaml file
https://github.com/kubernetes-sigs/vsphere-csi-driver/blob/master/manifests/1.14/deploy/vsphere-csi-controller-ss.yaml

Special notes for your reviewer:
Deploy CSI driver and customize the value of the FULL SYNC to different values.
Currently the default value is set to 30minutes both in the source files and yaml file. But with this change, if users change the FULL SYNC to different value it will be reflected in the container at runtime as well

Release note:

Fix ENV variable to support customization of FULL SYNC interval

Snapshot of the Deployment file:

kind: StatefulSet
apiVersion: apps/v1
metadata:
  name: vsphere-csi-controller
  namespace: kube-system
...
...
...
        - name: vsphere-syncer
          image: <repository:image-name:tag>
          args:
            - "--v=2"
          imagePullPolicy: "Always"
          env:
            - name: FULL_SYNC_INTERVAL_MINUTES
              value: "30"
            - name: VSPHERE_CSI_CONFIG
              value: "/etc/cloud/csi-vsphere.conf"
          volumeMounts:
            - mountPath: /etc/cloud
              name: vsphere-config-volume
              readOnly: true

[k8s-ci-robot]

Hi @chethanv28. Thanks for your PR.

I'm waiting for a kubernetes-sigs or kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[RaunakShah]

I'd suggest changing the environment variable in the YAML to FULL_SYNC_INTERVAL_MINUTES. Full Sync is a CNS concept and doesn't need the CSI prefix.

[chethanv28]

I'd suggest changing the environment variable in the YAML to FULL_SYNC_INTERVAL_MINUTES. Full Sync is a CNS concept and doesn't need the CSI prefix.

@RaunakShah I have addressed your review comment in the latest commit

[davidvonthenen]

/ok-to-test

[divyenpatel]

@chethanv28 please squash all your commits. LGTM

[chethanv28]

@chethanv28 please squash all your commits. LGTM

@divyenpatel I have squashed all the commits

[divyenpatel]

/lgtm

[divyenpatel]

/approve

[chethanv28]

/assign @dvonthenen
/assign @codenrhoden

[davidvonthenen]

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chethanv28, divyenpatel, dvonthenen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [dvonthenen]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[chethanv28]

Thanks for the approvals @dvonthenen and @divyenpatel