feat: added hostPID capability for linux daemonset #417

jamesalford · 2023-11-10T11:41:21Z

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind test
/kind failing-test
/kind flake

/kind feature

What this PR does / why we need it:
Adds the ability to add hostPID to the container spec for linux daemonset. This is used to execute scripts in init containers that modify the host storage

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Release note:

linux-foundation-easycla · 2023-11-10T11:41:25Z

The committers listed above are authorized under a signed CLA.

✅ login: jamesalford / name: James Alford (3e471ce)

k8s-ci-robot · 2023-11-10T11:41:29Z

Welcome @jamesalford!

It looks like this is your first PR to kubernetes-sigs/sig-storage-local-static-provisioner 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/sig-storage-local-static-provisioner has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

k8s-ci-robot · 2023-11-10T11:41:30Z

Hi @jamesalford. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot · 2023-11-10T11:41:34Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jamesalford
Once this PR has been reviewed and has the lgtm label, please assign jsafrane for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

andyzhangx

/ok-to-test

mauriciopoppe · 2023-12-12T21:50:37Z

helm/provisioner/templates/daemonset_linux.yaml

@@ -28,6 +28,9 @@ spec:
 {{ .Values.podAnnotations | toYaml | trim | indent 8 }}
 {{- end }}
    spec:
+{{- if .Values.hostPID }}
+      hostPID: true


Nit: Maybe this should be:

hostPID: {{ .Values.hostPID }}

The default value in the reference is false https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.27/#podspec-v1-core, also the value set from the chart is false so I think the above would work.

mauriciopoppe · 2023-12-12T21:50:54Z

helm/README.md

@@ -231,6 +231,7 @@ provisioner chart and their default values.
 | serviceMonitor.namespace                | The namespace Prometheus servicemonitor will be installed                                                                      | str      | `.Release.Namespace`                                          |
 | serviceMonitor.additionalLabels         | Additional labels for the servicemonitor                                                                                       | map      | `-`                                                           |
 | serviceMonitor.relabelings              | Additional metrics relabel_config                                                                                              | lists    | `-`                                                           |
+| hostPID                                 | Add `hostPID: true` to the container spec for linux daemonset.                                                                 | bool     | `false`                                                       |


If you consider the comment below then the docs should be updated too.

mauriciopoppe · 2023-12-12T21:51:51Z

/uncc @cofyc @saad-ali

k8s-triage-robot · 2024-03-11T22:24:12Z

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Mark this PR as fresh with /remove-lifecycle stale
Close this PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot · 2024-04-10T22:37:09Z

The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Mark this PR as fresh with /remove-lifecycle rotten
Close this PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot · 2024-05-10T22:40:31Z

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Reopen this PR with /reopen
Mark this PR as fresh with /remove-lifecycle rotten
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

k8s-ci-robot · 2024-05-10T22:40:36Z

@k8s-triage-robot: Closed this PR.

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied

After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied

After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Reopen this PR with /reopen

Mark this PR as fresh with /remove-lifecycle rotten

Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Added hostPID capability for linux daemonset

3e471ce

k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/feature Categorizes issue or PR as related to a new feature. labels Nov 10, 2023

k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Nov 10, 2023

k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Nov 10, 2023

k8s-ci-robot requested review from cofyc and saad-ali November 10, 2023 11:41

k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Nov 10, 2023

jamesalford changed the title ~~WIP: Added hostPID capability for linux daemonset~~ Added hostPID capability for linux daemonset Nov 20, 2023

k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 20, 2023

andyzhangx reviewed Dec 10, 2023

View reviewed changes

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 10, 2023

andyzhangx changed the title ~~Added hostPID capability for linux daemonset~~ feat: added hostPID capability for linux daemonset Dec 10, 2023

mauriciopoppe reviewed Dec 12, 2023

View reviewed changes

k8s-ci-robot removed request for cofyc and saad-ali December 12, 2023 21:51

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 11, 2024

k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Apr 10, 2024

k8s-ci-robot closed this May 10, 2024

jamesalford deleted the feature/hostPID branch June 4, 2024 10:55

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: added hostPID capability for linux daemonset #417

feat: added hostPID capability for linux daemonset #417

jamesalford commented Nov 10, 2023

linux-foundation-easycla bot commented Nov 10, 2023 •

edited

Loading

k8s-ci-robot commented Nov 10, 2023

k8s-ci-robot commented Nov 10, 2023

k8s-ci-robot commented Nov 10, 2023

andyzhangx left a comment

mauriciopoppe Dec 12, 2023

mauriciopoppe Dec 12, 2023

mauriciopoppe commented Dec 12, 2023

k8s-triage-robot commented Mar 11, 2024

k8s-triage-robot commented Apr 10, 2024

k8s-triage-robot commented May 10, 2024

k8s-ci-robot commented May 10, 2024

feat: added hostPID capability for linux daemonset #417

feat: added hostPID capability for linux daemonset #417

Conversation

jamesalford commented Nov 10, 2023

linux-foundation-easycla bot commented Nov 10, 2023 • edited Loading

k8s-ci-robot commented Nov 10, 2023

k8s-ci-robot commented Nov 10, 2023

k8s-ci-robot commented Nov 10, 2023

andyzhangx left a comment

Choose a reason for hiding this comment

mauriciopoppe Dec 12, 2023

Choose a reason for hiding this comment

mauriciopoppe Dec 12, 2023

Choose a reason for hiding this comment

mauriciopoppe commented Dec 12, 2023

k8s-triage-robot commented Mar 11, 2024

k8s-triage-robot commented Apr 10, 2024

k8s-triage-robot commented May 10, 2024

k8s-ci-robot commented May 10, 2024

linux-foundation-easycla bot commented Nov 10, 2023 •

edited

Loading