-
Notifications
You must be signed in to change notification settings - Fork 296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: validate SPCPS targetPaths match Pod UIDs #371
Conversation
Hi @tam7t. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ok-to-test
/retitle fix: validate SPCPS targetPaths match Pod UIDs |
/retitle fix: validate SPCPS targetPaths match Pod UIDs |
c349305
to
7f9b79f
Compare
a73a6cb
to
9003d29
Compare
9003d29
to
d00efa8
Compare
1305252
to
d9c0ee0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tam7t Just one small nit. Otherwise lgtm!
Could you also squash the commits?
Consolidated duplicate GetMountedFiles and GetPodUIDFromTargetPath as well. Apply suggestions from code review Co-authored-by: Rita Zhang <[email protected]> Co-authored-by: Anish Ramasekar <[email protected]> fix: include a check on volume name matches the targetPath k8sutil: refactor common func SPCVolume
3e67b95
to
c2cbb19
Compare
Done! |
/test pull-secrets-store-csi-driver-e2e-windows |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ritazh, tam7t The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Consolidated duplicate GetMountedFiles and GetPodUIDFromTargetPath as well.