Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace k8s.gcr.io with registry.k8s.io #538

Merged
merged 1 commit into from
Mar 6, 2023
Merged

Replace k8s.gcr.io with registry.k8s.io #538

merged 1 commit into from
Mar 6, 2023

Conversation

xmudrii
Copy link
Member

@xmudrii xmudrii commented Mar 6, 2023

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

This PR replaces all k8s.gcr.io references with registry.k8s.io. See the linked issue for more details.

Which issue(s) this PR fixes:
xref kubernetes/k8s.io#4738

Release note:

Replace all `k8s.gcr.io` references with `registry.k8s.io`

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 6, 2023
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 6, 2023
@xmudrii xmudrii mentioned this pull request Mar 6, 2023
Closed
85 tasks
Huang-Wei
Huang-Wei reviewed Mar 6, 2023
View reviewed changes
Copy link
Contributor

@Huang-Wei Huang-Wei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Thanks @xmudrii!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 6, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Huang-Wei, xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 6, 2023
@k8s-ci-robot k8s-ci-robot merged commit ded7f5c into kubernetes-sigs:master Mar 6, 2023
@xmudrii xmudrii deleted the registry-k8s-io branch March 8, 2023 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Huang-Wei Huang-Wei Huang-Wei left review comments

@cwdsuzhou cwdsuzhou Awaiting requested review from cwdsuzhou

@yuanchen8911 yuanchen8911 Awaiting requested review from yuanchen8911

Assignees

@Huang-Wei Huang-Wei

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xmudrii @k8s-ci-robot @Huang-Wei