Add new throttler pkg forked from nozzle/throttler #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
kind/feature
|
|
k8s-ci-robot
added
sig/release
Co-authored-by: Nozzle <[email protected]> Signed-off-by: Adolfo García Veytia (Puerco) <[email protected]>
Signed-off-by: Adolfo García Veytia (Puerco) <[email protected]>
Signed-off-by: Adolfo García Veytia (Puerco) <[email protected]>
Signed-off-by: Adolfo García Veytia (Puerco) <[email protected]>
Signed-off-by: Adolfo García Veytia (Puerco) <[email protected]>
…or channel + errorCount Signed-off-by: Adolfo García Veytia (Puerco) <[email protected]>
Signed-off-by: Adolfo García Veytia (Puerco) <[email protected]>
puerco
force-pushed
the
import-nozzle-throttle
branch
from
40dd0e8 to
7f870ce
Compare
Co-authored-by: Joe Bergevin <[email protected]> Signed-off-by: Adolfo García Veytia (Puerco) <[email protected]>
Co-authored-by: Joe Bergevin <[email protected]> Signed-off-by: Adolfo García Veytia (Puerco) <[email protected]>
Signed-off-by: Adolfo García Veytia (Puerco) <[email protected]>
Co-authored-by: Joe Bergevin <[email protected]> Signed-off-by: Adolfo García Veytia (Puerco) <[email protected]>
Signed-off-by: Adolfo García Veytia (Puerco) <[email protected]>
Signed-off-by: Adolfo García Veytia (Puerco) <[email protected]>
Signed-off-by: Adolfo García Veytia (Puerco) <[email protected]>
Signed-off-by: Adolfo García Veytia (Puerco) <[email protected]>
Signed-off-by: Adolfo García Veytia (Puerco) <[email protected]>
also changed order of channel sends/receives to send after updating atomic counters Signed-off-by: Adolfo García Veytia (Puerco) <[email protected]>
Signed-off-by: Adolfo García Veytia (Puerco) <[email protected]>
Signed-off-by: Adolfo García Veytia (Puerco) <[email protected]>
This commit imports the code from the nozzle/throttle module and imports it into the release-utils repo as the relegn team will take care of maintaining it. The original module commit history is preserved. Signed-off-by: Adolfo García Veytia (Puerco) <[email protected]>
Signed-off-by: Adolfo García Veytia (Puerco) <[email protected]>
This commit fixes the copyright notices for the the throttler files and adds a notice about the package fork. Signed-off-by: Adolfo García Veytia (Puerco) <[email protected]>
Signed-off-by: Adolfo García Veytia (Puerco) <[email protected]>
Signed-off-by: Adolfo García Veytia (Puerco) <[email protected]>
This commit mutes the linter warning for random/v2, for now we still support go 1.21. Drop this commit and move to random/v2 when we bump to go 1.22+ Signed-off-by: Adolfo García Veytia (Puerco) <[email protected]>
puerco
force-pushed
the
import-nozzle-throttle
branch
from
7f870ce to
fd37b22
Compare
k8s-ci-robot
added
cncf-cla: yes
I messed up during the import and applied the patches in throttle/throttle. This commit moves the new package source to the proper location. Sorry :( Signed-off-by: Adolfo García Veytia (Puerco) <[email protected]>
puerco
changed the title
puerco
changed the title
saschagrunert
approved these changes
Jul 23, 2024
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: puerco, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Not a big deal that you forked it, just surprising that you didn't file an issue first. There hasn't been a compelling reason for us to make any changes, so it wasn't unmaintained or abandoned, just considered complete, barring issue reports. |
|
Hey @derekperkins thanks for chiming in! I'm sorry, in the rush to get another feature in we didn't think this through. We should have filed an issue especially since we've been using the module for years, I'm happy to revert and we can contribute any patches back to you in the future. Apologies! |
|
Agreed on the revert here! |
|
OK, opened #111 to revert the fork! |
|
No worries, really not a big deal either way. If anything, it was an ego booster that it was important enough to fork :) I saw a few tweaked commits in this PR too that we're happy to pull in upstream, along with any other feedback you have. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
This commit imports a fork of the nozzle/throttler package.
As discussed in #107, this package is used in the release engineering tooling but has not had new commits in over six years so the release engineering team chose to adopt it to keep maintaining it.
Which issue(s) this PR fixes:
Follow-up to #107
Special notes for your reviewer:
I've imported the full commit history and added notices crediting the original package source and origin.
I also fixed the linter and updated the tests a little bit but they still need some improvement.
/cc @saschagrunert @xmudrii
Does this PR introduce a user-facing change?