Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use k8s-staging-images vs kubernetes-ci-images #248

Merged

Conversation

spiffxp
Copy link
Member

@spiffxp spiffxp commented Jul 29, 2021

Related:

I did this as a straight search-replace because it was unclear to me how exactly the files I changed are used.

I had initially tried using genref but it excluded v1beta1, and pulled in way more stuff, which is the sort of thing I'd expect a regular contributor to this repo to handle.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 29, 2021
@k8s-ci-robot k8s-ci-robot requested review from feloy and onlydole July 29, 2021 15:31
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 29, 2021
@spiffxp
Copy link
Member Author

spiffxp commented Jul 29, 2021

/cc @tengqm @neolit123

@k8s-ci-robot k8s-ci-robot requested review from neolit123 and tengqm July 29, 2021 15:37
Copy link
Member

@neolit123 neolit123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
this was changed in k/k here:
kubernetes/kubernetes@d067c2e

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 29, 2021
@tengqm
Copy link
Contributor

tengqm commented Jul 31, 2021

This is fine.
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: spiffxp, tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 31, 2021
@k8s-ci-robot k8s-ci-robot merged commit 336acc4 into kubernetes-sigs:master Jul 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants