Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

testing: Add fakes for file promotion packages (via counterfeiter) #418

Merged
merged 7 commits into from
Sep 11, 2021
Merged

testing: Add fakes for file promotion packages (via counterfeiter) #418

merged 7 commits into from
Sep 11, 2021

Conversation

justaugustus
Copy link
Contributor

@justaugustus justaugustus commented Sep 11, 2021 •
edited
Loading

What type of PR is this?

/kind cleanup design

What this PR does / why we need it:

  • internal: Init deps for counterfeiter
  • testing: Add counterfeiter directives for file promotion packages
  • testing: Add update-mocks target and update boilerplate files
  • filepromoter: Make syncFileInfo public
    ...in support of adding fakes.
  • generated: Run make update-mocks
  • Makefile: Add verify-mocks target
  • Fixup boilerplate for non-compliant files

/assign @puerco @Verolop @justinsb @cpanato
cc: @kubernetes-sigs/release-engineering

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/design Categorizes issue or PR as related to design. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 11, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justaugustus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added area/artifacts Issues or PRs related to the hosting of release artifacts for subprojects area/release-eng Issues or PRs related to the Release Engineering subproject approved Indicates a PR has been approved by an approver from all required OWNERS files. sig/release Categorizes an issue or PR as relevant to SIG Release. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. wg/k8s-infra labels Sep 11, 2021
@puerco
Copy link
Member

puerco commented Sep 11, 2021

Nice one, thanks !
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 11, 2021
@k8s-ci-robot k8s-ci-robot merged commit 7a8e612 into kubernetes-sigs:master Sep 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@puerco puerco Awaiting requested review from puerco

@xmudrii xmudrii Awaiting requested review from xmudrii

Assignees

@justinsb justinsb

@Verolop Verolop

@puerco puerco

@cpanato cpanato

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/artifacts Issues or PRs related to the hosting of release artifacts for subprojects area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/design Categorizes issue or PR as related to design. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. sig/release Categorizes an issue or PR as relevant to SIG Release. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@justaugustus @k8s-ci-robot @puerco @justinsb @Verolop @cpanato