-
Notifications
You must be signed in to change notification settings - Fork 556
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Canonical repo address is inconsistent with go import path #306
Comments
@smarterclayton @sergii-koshel-exa Could you help me review this issue? Thx :p |
We are planning to move this repository into a more kubernetes canonical organization. Once this happens the issue should resolve itself. |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
Stale issues rot after 30d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-contributor-experience at kubernetes/community. |
Rotten issues close after 30d of inactivity. Send feedback to sig-contributor-experience at kubernetes/community. |
@fejta-bot: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
The github.com/
directxman12/k8s-prometheus-adapter
repo was just renamed to github.com/DirectXMan12/k8s-prometheus-adapter
This means that the canonical github repo address now conflicts with canonical go import packages (for example,
"github.com/directxman12/k8s-prometheus-adapter/pkg/client"
, as referenced from https://github.com/DirectXMan12/k8s-prometheus-adapter/blob/v0.7.0/pkg/client/fake/client.go#L23)It is now very easy for downstream consumers (which don't import "github.com/directxman12/k8s-prometheus-adapter/..." packages) to accidentally clone and add imports to upper-case
"github.com/DirectXMan12/k8s-prometheus-adapter/..."
packages. This will create many pitfalls and break the module users. They may encounter errors:(This was possible before, but way harder to do accidentally, since all the links and clone commands from github agreed with the canonical go import packages)
Cautionary tale:
Please consider reverting the
directxman12
->DirectXMan12
rename.If the case change is here to stay, some things that would help a lot:
go get github.com/directxman12/k8s-prometheus-adapter
commands or others in the READMEs of all the go repos to guide consumers.The text was updated successfully, but these errors were encountered: