Cleanup for NodeFeature API being GA #1976
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: marquiz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
|
/milestone v0.17 |
✅ Deploy Preview for kubernetes-sigs-nfd ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
/assign @TessaIO |
Drop references to the gRPC API and don't suggest that NodeFeatureAPI could be disabled. Also update the developer guide for instructions running nfd components outside the cluster.
marquiz
force-pushed
the
devel/grpc-api-cleanup
branch
from
bcfe7d5 to
fc103a6
Compare
|
Updated. @fmuyassarov PTAL |
| For development and debugging it is possible to run nfd-master as a stand-alone | ||
| binary outside the cluster. The `-no-publish` flag can be used to prevent | ||
| nfd-master making changes to the nodes. If `-no-publish` is not set, nfd-master | ||
| also requires the `NODE_NAME` environment variable to be set for cleaning up | ||
| stale annotations. |
There was a problem hiding this comment.
quick question, KUBERNETES_NAMESPACE isn't needed for the master?
There was a problem hiding this comment.
Good question. And correct, it is not needed for nfd-master (the namespace env is required for those daemons that create CRs). The nfd-master watches CRs in all namespaces
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 610dcb43a2b5b90ef4ff053fcc6dd72c4b2e473e
|
Drop references to the gRPC API and don't suggest that NodeFeatureAPI could be disabled.
Also update the developer guide for instructions running nfd components outside the cluster.