Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add metrics system prefix #1956

Merged

Conversation

googs1025
Copy link
Member

For different components in the same project, metrics should be distinguished by different system prefixes.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 17, 2024
Copy link

netlify bot commented Nov 17, 2024

Deploy Preview for kubernetes-sigs-nfd ready!

Name Link
🔨 Latest commit e631a52
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-nfd/deploys/6747ce256e90b10008ae2c7e
😎 Deploy Preview https://deploy-preview-1956--kubernetes-sigs-nfd.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 17, 2024
@googs1025
Copy link
Member Author

/test pull-node-feature-discovery-build-image-cross-generic

Copy link
Member

@fmuyassarov fmuyassarov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 20, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 360ce1ff18308c869fabebf47c4b58ab60c01455

Copy link
Contributor

@marquiz marquiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @googs1025 for the improvement.

Could you also update the docs (docs/deployment/metrics.md) and the example dashboard (examples/grafana-dashboard.json) to have them in sync?

@googs1025
Copy link
Member Author

Thank you @googs1025 for the improvement.

Could you also update the docs (docs/deployment/metrics.md) and the example dashboard (examples/grafana-dashboard.json) to have them in sync?

OK, I can do this weekend. 😄

@googs1025 googs1025 force-pushed the chore/add_metrics_prefix branch from 902f6f2 to 6f957bd Compare November 23, 2024 07:08
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 23, 2024
@googs1025
Copy link
Member Author

Thank you @googs1025 for the improvement.

Could you also update the docs (docs/deployment/metrics.md) and the example dashboard (examples/grafana-dashboard.json) to have them in sync?

done

Copy link
Member

@fmuyassarov fmuyassarov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
ping @marquiz

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 25, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: ad070102f0664d397ed0a923f4b3be3bd125124d

@googs1025 googs1025 requested a review from marquiz November 27, 2024 12:16
| `nfd_worker_build_info` | Gauge | Version from which nfd-worker was built |
| `nfd_gc_build_info` | Gauge | Version from which nfd-gc was built |
| `nfd_topology_updater_build_info` | Gauge | Version from which nfd-topology-updater was built |
| `nfd_master_node_update_requests_total` | Counter | Number of node update requests received by the master over gRPC |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small nit: could you keep the columns aligned

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@googs1025 googs1025 force-pushed the chore/add_metrics_prefix branch from 6f957bd to e631a52 Compare November 28, 2024 01:57
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 28, 2024
@googs1025 googs1025 requested a review from marquiz November 28, 2024 02:00
Copy link
Contributor

@marquiz marquiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @googs1025 for the update
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 28, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: googs1025, marquiz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 8d8f4fd856a7e2c10960d1cf0d85020621a3a9c3

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 28, 2024
@k8s-ci-robot k8s-ci-robot merged commit 443913e into kubernetes-sigs:master Nov 28, 2024
12 checks passed
@marquiz marquiz mentioned this pull request Dec 12, 2024
25 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants