-
Notifications
You must be signed in to change notification settings - Fork 253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add metrics system prefix #1956
chore: add metrics system prefix #1956
Conversation
✅ Deploy Preview for kubernetes-sigs-nfd ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
/test pull-node-feature-discovery-build-image-cross-generic |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
LGTM label has been added. Git tree hash: 360ce1ff18308c869fabebf47c4b58ab60c01455
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @googs1025 for the improvement.
Could you also update the docs (docs/deployment/metrics.md
) and the example dashboard (examples/grafana-dashboard.json
) to have them in sync?
OK, I can do this weekend. 😄 |
902f6f2
to
6f957bd
Compare
done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
ping @marquiz
LGTM label has been added. Git tree hash: ad070102f0664d397ed0a923f4b3be3bd125124d
|
docs/deployment/metrics.md
Outdated
| `nfd_worker_build_info` | Gauge | Version from which nfd-worker was built | | ||
| `nfd_gc_build_info` | Gauge | Version from which nfd-gc was built | | ||
| `nfd_topology_updater_build_info` | Gauge | Version from which nfd-topology-updater was built | | ||
| `nfd_master_node_update_requests_total` | Counter | Number of node update requests received by the master over gRPC | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
small nit: could you keep the columns aligned
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
6f957bd
to
e631a52
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @googs1025 for the update
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: googs1025, marquiz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
LGTM label has been added. Git tree hash: 8d8f4fd856a7e2c10960d1cf0d85020621a3a9c3
|
For different components in the same project, metrics should be distinguished by different system prefixes.