Drop NFD gRPC API #1910

ArangoGutierrez · 2024-10-15T14:39:40Z

netlify · 2024-10-15T14:39:56Z

✅ Deploy Preview for kubernetes-sigs-nfd ready!

Name	Link
🔨 Latest commit	`0bd82cf`
🔍 Latest deploy log	https://app.netlify.com/sites/kubernetes-sigs-nfd/deploys/6720ee03d3b7d4000802ec03
😎 Deploy Preview	https://deploy-preview-1910--kubernetes-sigs-nfd.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

ArangoGutierrez · 2024-10-15T14:39:57Z

/assign @marquiz

ArangoGutierrez · 2024-10-17T11:16:13Z

Documentation drop is on PR #1912

marquiz

Thanks @ArangoGutierrez for taking this effort. It's a good start. A few comments below.

Also a nit about the commit messages 🙄 Let's specify context in format like docs: xyzzy... instead of bracketted [Documentation]

cmd/nfd-master/main.go

pkg/nfd-worker/nfd-worker.go

marquiz · 2024-10-23T10:43:30Z

deployment/helm/node-feature-discovery/templates/master.yaml

There seems to be some stale tls leftovers in templates/topologyupdater.yaml as well. Drop those, too

deployment/helm/node-feature-discovery/values.yaml

marquiz · 2024-10-23T10:49:50Z

vendor/github.com/Microsoft/go-winio/.gitattributes

Adding vendor/?? Let's not at least do it in this PR

meh this was a fat finger, not intended. my bad

ArangoGutierrez · 2024-10-24T09:58:22Z

Thanks @ArangoGutierrez for taking this effort. It's a good start. A few comments below.

Also a nit about the commit messages 🙄 Let's specify context in format like docs: xyzzy... instead of bracketted [Documentation]

dropped that commit, as I want documentation to be a stand-alone PR

ArangoGutierrez · 2024-10-24T10:36:00Z

/test pull-node-feature-discovery-e2e-test-master

ArangoGutierrez · 2024-10-24T10:51:52Z

/milestone v0.17

ArangoGutierrez · 2024-10-25T18:39:32Z

@marquiz PR is ready for review

marquiz · 2024-10-28T14:41:34Z

pkg/nfd-master/nfd-master.go

-	}
-
-	serverOpts := []grpc.ServerOption{}
-	tlsConfig := utils.TlsConfig{}


Drop the TlsConfig stuff from the utils package, too

cmd/nfd-master/main.go

marquiz · 2024-10-28T14:44:19Z

cmd/nfd-master/main.go

-			klog.InfoS("-key-file is deprecated, will be removed in a future release along with the deprecated gRPC API")
-		case "port":
-			klog.InfoS("-port is deprecated, will be removed in a future release along with the deprecated gRPC API")
-		case "verify-node-name":


Drop the -verify-node-name flag from below, too

marquiz · 2024-10-28T14:45:24Z

cmd/nfd-master/main.go

-			klog.InfoS("-cert-file is deprecated, will be removed in a future release along with the deprecated gRPC API")
-		case "key-file":
-			klog.InfoS("-key-file is deprecated, will be removed in a future release along with the deprecated gRPC API")
-		case "port":


Drop the -port flag from below, too

deployment/helm/node-feature-discovery/values.yaml

marquiz · 2024-10-28T14:48:07Z

pkg/nfd-master/nfd-master.go

 	ConfigFile    string
 	Instance      string
-	KeyFile       string


Drop port and verifynodename, too

pkg/nfd-worker/nfd-worker.go

ArangoGutierrez · 2024-10-29T12:31:06Z

/test pull-node-feature-discovery-build-image-cross-generic

ArangoGutierrez · 2024-10-29T13:05:58Z

/test pull-node-feature-discovery-build-image-cross-generic

ArangoGutierrez · 2024-10-29T13:19:29Z

/test pull-node-feature-discovery-build-image-cross-generic

marquiz · 2024-10-29T13:57:01Z

pkg/nfd-worker/nfd-worker.go

@@ -303,14 +277,6 @@ func (w *nfdWorker) Run() error {
 		return err
 	}

-	// Create watcher for TLS certificates
-	w.certWatch, err = utils.CreateFsWatcher(time.Second, w.args.CaFile, w.args.CertFile, w.args.KeyFile)


Let's drop certWatch from the nfdWorker struct, too

marquiz · 2024-10-29T13:59:52Z

pkg/nfd-master/nfd-master.go

+	Instance   string
+	Klog       map[string]*utils.KlogFlagVal
+	Kubeconfig string
+	Port       int


We should be able to drop the VerifyNodeName below, too

Signed-off-by: Carlos Eduardo Arango Gutierrez <[email protected]>

ArangoGutierrez · 2024-10-30T09:48:01Z

/test pull-node-feature-discovery-build-image-cross-generic

marquiz

Thank you @ArangoGutierrez for this effort. If/when we missed something let's drop those with follow-up PRs
/lgtm

k8s-ci-robot · 2024-10-30T09:54:17Z

LGTM label has been added.

Git tree hash: fde9597d75a484789afef44f017b681530fc32b5

k8s-ci-robot · 2024-10-30T09:54:24Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ArangoGutierrez, marquiz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [ArangoGutierrez,marquiz]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Drop NFD gRPC API

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 15, 2024

ArangoGutierrez requested review from marquiz and TessaIO October 15, 2024 14:39

k8s-ci-robot assigned marquiz Oct 15, 2024

k8s-ci-robot requested review from jjacobelli and PiotrProkop October 15, 2024 14:40

k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Oct 15, 2024

ArangoGutierrez force-pushed the I/1546 branch 2 times, most recently from 69d7a98 to b97027c Compare October 17, 2024 11:15

ArangoGutierrez force-pushed the I/1546 branch 3 times, most recently from 5657490 to 7cec6ed Compare October 17, 2024 13:50

marquiz reviewed Oct 23, 2024

View reviewed changes

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 23, 2024

ArangoGutierrez force-pushed the I/1546 branch 2 times, most recently from 7145055 to 5fb7a44 Compare October 24, 2024 09:58

k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 24, 2024

ArangoGutierrez requested a review from marquiz October 24, 2024 09:59

ArangoGutierrez force-pushed the I/1546 branch 2 times, most recently from ed92a84 to e6ee7ca Compare October 24, 2024 10:04

ArangoGutierrez force-pushed the I/1546 branch from e6ee7ca to af02c0c Compare October 24, 2024 10:51

k8s-ci-robot added this to the v0.17 milestone Oct 24, 2024

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 24, 2024

ArangoGutierrez force-pushed the I/1546 branch from af02c0c to c98b504 Compare October 25, 2024 17:22

k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 25, 2024

ArangoGutierrez force-pushed the I/1546 branch from c98b504 to 003650c Compare October 25, 2024 18:20

marquiz reviewed Oct 28, 2024

View reviewed changes

ArangoGutierrez requested a review from marquiz October 29, 2024 10:00

ArangoGutierrez force-pushed the I/1546 branch from 003650c to e56f74b Compare October 29, 2024 10:00

marquiz reviewed Oct 29, 2024

View reviewed changes

Drop NFD gRPC API

0bd82cf

Signed-off-by: Carlos Eduardo Arango Gutierrez <[email protected]>

ArangoGutierrez force-pushed the I/1546 branch from e56f74b to 0bd82cf Compare October 29, 2024 14:15

ArangoGutierrez requested a review from marquiz October 29, 2024 14:15

marquiz approved these changes Oct 30, 2024

View reviewed changes

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 30, 2024

k8s-ci-robot merged commit 242410d into kubernetes-sigs:master Oct 30, 2024
10 checks passed

ArangoGutierrez pushed a commit to ArangoGutierrez/node-feature-discovery that referenced this pull request Oct 30, 2024

Merge pull request kubernetes-sigs#1910 from ArangoGutierrez/I/1546

f4a1f87

Drop NFD gRPC API

ArangoGutierrez pushed a commit to ArangoGutierrez/node-feature-discovery that referenced this pull request Nov 4, 2024

Merge pull request kubernetes-sigs#1910 from ArangoGutierrez/I/1546

61a96f7

Drop NFD gRPC API

marquiz mentioned this pull request Dec 12, 2024

Release v0.17 #1875

Open

24 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Drop NFD gRPC API #1910

Drop NFD gRPC API #1910

ArangoGutierrez commented Oct 15, 2024

netlify bot commented Oct 15, 2024 •

edited

Loading

ArangoGutierrez commented Oct 15, 2024

ArangoGutierrez commented Oct 17, 2024

marquiz left a comment

marquiz Oct 23, 2024

ArangoGutierrez Oct 24, 2024

marquiz Oct 23, 2024

ArangoGutierrez Oct 24, 2024

ArangoGutierrez Oct 24, 2024

ArangoGutierrez commented Oct 24, 2024

ArangoGutierrez commented Oct 24, 2024

ArangoGutierrez commented Oct 24, 2024

ArangoGutierrez commented Oct 25, 2024

marquiz Oct 28, 2024

marquiz Oct 28, 2024

marquiz Oct 28, 2024

marquiz Oct 28, 2024

ArangoGutierrez commented Oct 29, 2024

ArangoGutierrez commented Oct 29, 2024

ArangoGutierrez commented Oct 29, 2024

marquiz Oct 29, 2024

ArangoGutierrez Oct 29, 2024

marquiz Oct 29, 2024

ArangoGutierrez Oct 29, 2024

ArangoGutierrez commented Oct 30, 2024

marquiz left a comment

k8s-ci-robot commented Oct 30, 2024

k8s-ci-robot commented Oct 30, 2024

Drop NFD gRPC API #1910

Drop NFD gRPC API #1910

Conversation

ArangoGutierrez commented Oct 15, 2024

netlify bot commented Oct 15, 2024 • edited Loading

✅ Deploy Preview for kubernetes-sigs-nfd ready!

ArangoGutierrez commented Oct 15, 2024

ArangoGutierrez commented Oct 17, 2024

marquiz left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ArangoGutierrez commented Oct 24, 2024

ArangoGutierrez commented Oct 24, 2024

ArangoGutierrez commented Oct 24, 2024

ArangoGutierrez commented Oct 25, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ArangoGutierrez commented Oct 29, 2024

ArangoGutierrez commented Oct 29, 2024

ArangoGutierrez commented Oct 29, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ArangoGutierrez commented Oct 30, 2024

marquiz left a comment

Choose a reason for hiding this comment

k8s-ci-robot commented Oct 30, 2024

k8s-ci-robot commented Oct 30, 2024

netlify bot commented Oct 15, 2024 •

edited

Loading