Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github: specify workflow permissions #1906

Merged

Conversation

marquiz
Copy link
Contributor

@marquiz marquiz commented Oct 14, 2024

Update gh-pages has started failing with default permissions. It needs write permissions to be able to push to the gh-pages branch.

Update gh-pages has started failing with default permissions. It needs
write permissions to be able to push to the gh-pages branch.
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: marquiz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 14, 2024
@marquiz
Copy link
Contributor Author

marquiz commented Oct 14, 2024

/assign @ArangoGutierrez
/cc @tobiasgiese

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 14, 2024
Copy link

netlify bot commented Oct 14, 2024

Deploy Preview for kubernetes-sigs-nfd ready!

Name Link
🔨 Latest commit e17a9e5
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-nfd/deploys/670d6a83e36bad00081e4552
😎 Deploy Preview https://deploy-preview-1906--kubernetes-sigs-nfd.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@tobiasgiese
Copy link
Member

seems reasonable to me
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 14, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 7ef477a689ceae5cabc7124afdc0d3cd3458e136

@k8s-ci-robot k8s-ci-robot merged commit 391e8dc into kubernetes-sigs:master Oct 14, 2024
6 checks passed
@tobiasgiese
Copy link
Member

/cherry-pick release-0.16

@k8s-infra-cherrypick-robot

@tobiasgiese: new pull request created: #1907

In response to this:

/cherry-pick release-0.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@marquiz
Copy link
Contributor Author

marquiz commented Oct 23, 2024

/cherry-pick release-0.15

@k8s-infra-cherrypick-robot

@marquiz: new pull request created: #1926

In response to this:

/cherry-pick release-0.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants