Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

helm: rename args chart value to extraArgs #1880

Merged
merged 1 commit into from
Sep 18, 2024
Merged

helm: rename args chart value to extraArgs #1880

merged 1 commit into from
Sep 18, 2024

Conversation

marquiz
Copy link
Contributor

@marquiz marquiz commented Sep 18, 2024

The "args" value is not yet part of any release so this is not a breaking change.

@marquiz
helm: rename args chart value to extraArgs
843fc93 
The "args" value is not yet part of any release so this is not a
breaking change.
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 18, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: marquiz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 18, 2024
@netlify Netlify
Copy link

netlify bot commented Sep 18, 2024 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-nfd ready!

Name Link
🔨 Latest commit 843fc93
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-nfd/deploys/66eae87ff792780008d77e3e
😎 Deploy Preview https://deploy-preview-1880--kubernetes-sigs-nfd.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@marquiz
Copy link
Contributor Author

marquiz commented Sep 18, 2024

Refs #1878
/assign @ArangoGutierrez
/cc @tobiasgiese

@tobiasgiese
Copy link
Member

tobiasgiese commented Sep 18, 2024 •
edited
Loading

/lgtm

Thanks! :)
Will align #1878 after this PR is merged to resolve the conflicts

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 18, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 77224bdc73f8e00c76c9906fd1b8fb78ec87714d

@k8s-ci-robot k8s-ci-robot merged commit fc4cc13 into kubernetes-sigs:master Sep 18, 2024
9 checks passed
@marquiz marquiz deleted the devel/helm-args branch September 18, 2024 14:56
@marquiz marquiz mentioned this pull request Dec 12, 2024
Open
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArangoGutierrez ArangoGutierrez Awaiting requested review from ArangoGutierrez

@kad kad Awaiting requested review from kad

@tobiasgiese tobiasgiese Awaiting requested review from tobiasgiese

Assignees

@ArangoGutierrez ArangoGutierrez

@tobiasgiese tobiasgiese

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@marquiz @k8s-ci-robot @tobiasgiese @ArangoGutierrez