Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nfd-master: cleanup updater-pool method args #1876

Merged
merged 1 commit into from
Sep 16, 2024

Conversation

marquiz
Copy link
Contributor

@marquiz marquiz commented Sep 16, 2024

We store the work queues in the updater pool struct so we don't need to pass those as function arguments.

We store the work queues in the updater pool struct so we don't need to
pass those as function arguments.
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: marquiz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 16, 2024
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 16, 2024
Copy link

netlify bot commented Sep 16, 2024

Deploy Preview for kubernetes-sigs-nfd ready!

Name Link
🔨 Latest commit 9fad67e
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-nfd/deploys/66e81bb972749700087101f8
😎 Deploy Preview https://deploy-preview-1876--kubernetes-sigs-nfd.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 16, 2024
@marquiz
Copy link
Contributor Author

marquiz commented Sep 16, 2024

/assign @TessaIO @ArangoGutierrez

@TessaIO
Copy link
Member

TessaIO commented Sep 16, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 16, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: a744ef5eb9a20a19a48db3b64220af56e5c15ca5

@k8s-ci-robot k8s-ci-robot merged commit 1217773 into kubernetes-sigs:master Sep 16, 2024
10 checks passed
@marquiz marquiz deleted the devel/master-refactor branch September 16, 2024 13:22
@marquiz marquiz mentioned this pull request Dec 12, 2024
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants