-
Notifications
You must be signed in to change notification settings - Fork 247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
source/system: Add reading product name information #1871
source/system: Add reading product name information #1871
Conversation
Welcome @superbrothers! |
Hi @superbrothers. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
✅ Deploy Preview for kubernetes-sigs-nfd ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @superbrothers for the improvement. Looks fine to me
/ok-to-test
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: marquiz, superbrothers The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/assign @ArangoGutierrez |
/lgtm |
LGTM label has been added. Git tree hash: 5def7205973dcce242bc3d15e30ad30cbb02d91f
|
This PR adds Add reading product name information from
/sys/devices/virtual/dmi/id/product_name
.I want to add this feature because I want to label based on the product name of the compute machine.