nfd-master: proper shutdown of nfd api informers

[marquiz]

Stop blocking on event channels when the api controller is stopped.
Ensures that the nfd API informer factory is properly shut down and all
resources released when stop() is called. This eliminates a memory leak
on re-configure events when leader election is enabled.

Fixes: #1841

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: marquiz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [marquiz]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[netlify]

✅ Deploy Preview for kubernetes-sigs-nfd ready!

Name	Link
🔨 Latest commit	2bb8a72
🔍 Latest deploy log	https://app.netlify.com/sites/kubernetes-sigs-nfd/deploys/66c4657ff741e1000882b531
😎 Deploy Preview	https://deploy-preview-1848--kubernetes-sigs-nfd.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[marquiz]

/assign @ArangoGutierrez @TessaIO
/cc @subnet-dev
/cherry-pick release-0.16

[k8s-infra-cherrypick-robot]

@marquiz: once the present PR merges, I will cherry-pick it on top of release-0.16 in a new PR and assign it to you.

In response to this:

/assign @ArangoGutierrez @TessaIO
/cc @subnet-dev
/cherry-pick release-0.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[k8s-ci-robot]

@marquiz: GitHub didn't allow me to request PR reviews from the following users: subnet-dev.

Note that only kubernetes-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/assign @ArangoGutierrez @TessaIO
/cc @subnet-dev
/cherry-pick release-0.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[marquiz]

Still some investigation going on
/hold

[marquiz]

Came up with a neater solution
/unhold

[TessaIO]

/lgtm

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: 7e6222d68588302edd2c3ce0f25aec85b5907dc0

[k8s-infra-cherrypick-robot]

@marquiz: #1848 failed to apply on top of branch "release-0.16":

Applying: nfd-master: proper shutdown of nfd api informers
Using index info to reconstruct a base tree...
M	pkg/nfd-master/nfd-api-controller.go
M	pkg/nfd-master/nfd-master.go
Falling back to patching base and 3-way merge...
Auto-merging pkg/nfd-master/nfd-master.go
CONFLICT (content): Merge conflict in pkg/nfd-master/nfd-master.go
Auto-merging pkg/nfd-master/nfd-api-controller.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 nfd-master: proper shutdown of nfd api informers
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/assign @ArangoGutierrez @TessaIO
/cc @subnet-dev
/cherry-pick release-0.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.