Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nfd-master: explicit state variable for the node updater pool #1844

Merged

Conversation

marquiz
Copy link
Contributor

@marquiz marquiz commented Aug 19, 2024

No description provided.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: marquiz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 19, 2024
@marquiz
Copy link
Contributor Author

marquiz commented Aug 19, 2024

/assign @ArangoGutierrez

Copy link

netlify bot commented Aug 19, 2024

Deploy Preview for kubernetes-sigs-nfd ready!

Name Link
🔨 Latest commit 0d3c1ac
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-nfd/deploys/66c328251ccc5d00081cd723
😎 Deploy Preview https://deploy-preview-1844--kubernetes-sigs-nfd.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

}

if u.nfgQueue == nil || u.nfgQueue.ShuttingDown() {
if !u.started {
Copy link
Member

@TessaIO TessaIO Aug 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why don't we use the u.running function?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As that's also behind a lock

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perfect thanks, didn't see the first lock 😄

@TessaIO
Copy link
Member

TessaIO commented Aug 19, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 19, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 77bb997a0328e627f92f2e258c3fa991bf24eca2

@k8s-ci-robot k8s-ci-robot merged commit df7f65c into kubernetes-sigs:master Aug 19, 2024
10 checks passed
@marquiz marquiz deleted the devel/updater-pool-started branch August 19, 2024 15:29
@marquiz marquiz mentioned this pull request Dec 12, 2024
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants