-
Notifications
You must be signed in to change notification settings - Fork 247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: use jekyll-rtd-theme from a ruby gem #1829
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: marquiz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
✅ Deploy Preview for kubernetes-sigs-nfd ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
/assign @fmuyassarov @ArangoGutierrez |
@marquiz: once the present PR merges, I will cherry-pick it on top of release-0.16 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
808c225
to
ea8205c
Compare
ea8205c
to
a88ee74
Compare
be77ca8
to
a65e828
Compare
fbcffb5
to
c91b0dc
Compare
0c61d1d
to
595df2f
Compare
f44412d
to
6864a92
Compare
The upstream repo (and the release downloads) github.com/rundocs/jekyll-rtd-theme has been deleted. This broke our docs generation as the remote theme configuration depended on downloading the release artefact. This patch changes the docs building to use a Ruby gem instead of the remote theme setting. To complicate matters, the gem has an seemingly incorrect (too strict) version dependency. To mitigate this, we now install bundler-override plugin to ignore this particular dependency. The netlify conf is a hack, but I wasn't able to figure out a way how to install the bundler-override plugin without doing all ruby initialization in the build command.
6864a92
to
b2bc18f
Compare
Finally I was able to make the netlify conf work. @ArangoGutierrez @fmuyassarov PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job @marquiz !
/lgtm
LGTM label has been added. Git tree hash: 2245fc6373a9de49db43654d728331d3b62eccb1
|
@marquiz: new pull request created: #1830 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/cherry-pick release-0.15 |
@marquiz: new pull request created: #1927 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
The upstream repo (and the release downloads)
github.com/rundocs/jekyll-rtd-theme has been deleted. This broke our docs generation as the remote theme configuration depended on downloading the release artefact.
This patch changes the docs building to use a Ruby gem instead of the remote theme setting. To complicate matters, the gem has an seemingly incorrect (too strict) version dependency. To mitigate this, we now install bundler-override plugin to ignore this particular dependency.