Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nfd-master: check nfd api informer cache sync result #1809

Merged

Conversation

marquiz
Copy link
Contributor

@marquiz marquiz commented Jul 25, 2024

Bail out if there were errors in syncing the cache of any resource.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 25, 2024
@marquiz
Copy link
Contributor Author

marquiz commented Jul 25, 2024

/assign @ArangoGutierrez

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 25, 2024
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 25, 2024
Copy link

netlify bot commented Jul 25, 2024

Deploy Preview for kubernetes-sigs-nfd ready!

Name Link
🔨 Latest commit ea3243f
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-nfd/deploys/66a1f7a82d4e8a000873863d
😎 Deploy Preview https://deploy-preview-1809--kubernetes-sigs-nfd.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@marquiz marquiz force-pushed the devel/informer-cache-sync branch 2 times, most recently from ecc648e to 74defa4 Compare July 25, 2024 06:40
Bail out if there were errors in syncing the cache of any resource.
@marquiz marquiz force-pushed the devel/informer-cache-sync branch from 74defa4 to ea3243f Compare July 25, 2024 06:58
Copy link
Contributor

@ArangoGutierrez ArangoGutierrez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to add more "chaos" scenarios to our E2E suite
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 25, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ArangoGutierrez, marquiz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [ArangoGutierrez,marquiz]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 6216ce125384090fb9459c5d756f08540a561869

@k8s-ci-robot k8s-ci-robot merged commit bd8d74d into kubernetes-sigs:master Jul 25, 2024
10 checks passed
@marquiz marquiz deleted the devel/informer-cache-sync branch July 25, 2024 08:32
@TessaIO
Copy link
Member

TessaIO commented Jul 25, 2024

We need to add more "chaos" scenarios to our E2E suite /lgtm

@ArangoGutierrez should we create a ticket for that?

@ahmetb
Copy link
Member

ahmetb commented Jul 25, 2024

This is in response to #1802, right?

@marquiz
Copy link
Contributor Author

marquiz commented Jul 26, 2024

This is in response to #1802, right?

Kinda. Inspired by it but not (afaiu) fixing anything you encountered. WaitForCacheSync blocks and I'm not entirely sure in which scenarios it returns with caches not synced but we'd better catch those situations without falling through unnoticed.

@marquiz marquiz mentioned this pull request Dec 12, 2024
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants