Helm: Add revision history limit for worker daemonset

[rouke-broersma]

#1782 added support for setting revision history limit for master and gc replicas. This PR adds the same for worker replicas.

Fix #1759

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: rouke-broersma / name: Rouke Broersma (63e45fc, 8e22dec, d48aee0, 2f0f7a8)

[k8s-ci-robot]

Welcome @rouke-broersma!

It looks like this is your first PR to kubernetes-sigs/node-feature-discovery 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/node-feature-discovery has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @rouke-broersma. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[netlify]

✅ Deploy Preview for kubernetes-sigs-nfd ready!

Name	Link
🔨 Latest commit	2f0f7a8
🔍 Latest deploy log	https://app.netlify.com/sites/kubernetes-sigs-nfd/deploys/6698b2ffbeddf7000799db55
😎 Deploy Preview	https://deploy-preview-1797--kubernetes-sigs-nfd.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[marquiz]

Thanks @rouke-broersma for this improvement. The daemonsets being missing in #1782 somehow slipped through my (sloppy) review 😇

In addition to nfd-worker, could you also add the setting for the nfd-topology-updater DaemonSet.

[rouke-broersma]

Yes I'll do that shortly

[marquiz]

Looks good to me!
/assign @ArangoGutierrez

/ok-to-test
/cherry-pick release-0.16

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: marquiz, rouke-broersma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [marquiz]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[marquiz]

/label tide/merge-method-squash

[marquiz]

/lgtm

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: 27d8f61ced9a3615f211b4d04388cfe55d0f0502

[marquiz]

/cherry-pick release-0.16

[k8s-infra-cherrypick-robot]

@marquiz: #1797 failed to apply on top of branch "release-0.16":

Applying: Helm: Add revision history limit for worker daemonset
Using index info to reconstruct a base tree...
M	deployment/helm/node-feature-discovery/templates/worker.yaml
M	deployment/helm/node-feature-discovery/values.yaml
M	docs/deployment/helm.md
Falling back to patching base and 3-way merge...
Auto-merging docs/deployment/helm.md
CONFLICT (content): Merge conflict in docs/deployment/helm.md
Auto-merging deployment/helm/node-feature-discovery/values.yaml
Auto-merging deployment/helm/node-feature-discovery/templates/worker.yaml
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Helm: Add revision history limit for worker daemonset
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-0.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.