Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test/e2e: set topology-updater sleep-interval in podfingerprint test #1792

Merged
merged 1 commit into from
Jul 16, 2024

Conversation

marquiz
Copy link
Contributor

@marquiz marquiz commented Jul 16, 2024

Attempt to eliminate flakiness in CI.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: marquiz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 16, 2024
Copy link

netlify bot commented Jul 16, 2024

Deploy Preview for kubernetes-sigs-nfd ready!

Name Link
🔨 Latest commit 5a81f74
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-nfd/deploys/66962053ad284000085d62eb
😎 Deploy Preview https://deploy-preview-1792--kubernetes-sigs-nfd.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Run topology-updater with short sleep-interval to try to eliminate
flakiness in CI.
@marquiz marquiz force-pushed the devel/e2e-timeout branch from 806f4ab to 5a81f74 Compare July 16, 2024 07:25
@marquiz
Copy link
Contributor Author

marquiz commented Jul 16, 2024

PR updated
/retitle test/e2e: set topology-updater sleep-interval in podfingerprint test

@k8s-ci-robot k8s-ci-robot changed the title test/e2e: increase timeout in podfingerprint topology-updater test test/e2e: set topology-updater sleep-interval in podfingerprint test Jul 16, 2024
@marquiz
Copy link
Contributor Author

marquiz commented Jul 16, 2024

It seems it defaults to 60s, hence the flakiness

Yup, need to go through all the tests. I think we should specify short sleep-interval in every test. Fight flakiness and make the tests complete much more quickly(?)

@PiotrProkop
Copy link
Contributor

Yeah, it should speed up tests.
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 16, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 8b5b34a3454769033e32f161d6082c9a5d6b9849

@k8s-ci-robot k8s-ci-robot merged commit ea199c7 into kubernetes-sigs:master Jul 16, 2024
10 checks passed
@marquiz marquiz deleted the devel/e2e-timeout branch July 16, 2024 08:29
@marquiz marquiz mentioned this pull request Dec 12, 2024
25 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants