Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: take into consideration possibility of having empty line in swap file #1781

Merged
merged 1 commit into from
Jul 12, 2024
Merged

fix: take into consideration possibility of having empty line in swap file #1781

merged 1 commit into from
Jul 12, 2024

Conversation

TessaIO
Copy link
Member

@TessaIO TessaIO commented Jul 10, 2024

Closes #1751

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 10, 2024
@netlify Netlify
Copy link

netlify bot commented Jul 10, 2024 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-nfd ready!

Name Link
🔨 Latest commit 316fe71
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-nfd/deploys/66903a661b8d62000873a7b7
😎 Deploy Preview https://deploy-preview-1781--kubernetes-sigs-nfd.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@TessaIO
Copy link
Member Author

TessaIO commented Jul 10, 2024

/cc @marquiz

@k8s-ci-robot k8s-ci-robot requested a review from marquiz July 10, 2024 18:49
marquiz
marquiz reviewed Jul 11, 2024
View reviewed changes
source/memory/memory.go Outdated Show resolved Hide resolved
@marquiz
Copy link
Contributor

marquiz commented Jul 11, 2024

/cc linuxdaemon

@k8s-ci-robot
Copy link
Contributor

@marquiz: GitHub didn't allow me to request PR reviews from the following users: linuxdaemon.

Note that only kubernetes-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc linuxdaemon

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@marquiz
Copy link
Contributor

marquiz commented Jul 11, 2024

/cherry-pick release-0.16

@k8s-infra-cherrypick-robot
Copy link

@marquiz: once the present PR merges, I will cherry-pick it on top of release-0.16 in a new PR and assign it to you.

In response to this:

/cherry-pick release-0.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@TessaIO TessaIO force-pushed the fix-swap-empty-line branch from 0ef1c49 to d596ce2 Compare July 11, 2024 20:02
@TessaIO TessaIO force-pushed the fix-swap-empty-line branch from d596ce2 to 316fe71 Compare July 11, 2024 20:02
@TessaIO TessaIO requested a review from marquiz July 11, 2024 20:03
marquiz
marquiz approved these changes Jul 12, 2024
View reviewed changes
Copy link
Contributor

@marquiz marquiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @TessaIO for helping with this!

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: marquiz, TessaIO

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 12, 2024
@marquiz
Copy link
Contributor

marquiz commented Jul 12, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 12, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 5c20a5cf99f8855c3912b0078f2f00d14c532338

@k8s-ci-robot k8s-ci-robot merged commit 98e9091 into kubernetes-sigs:master Jul 12, 2024
10 checks passed
@k8s-infra-cherrypick-robot
Copy link

@marquiz: new pull request created: #1784

In response to this:

/cherry-pick release-0.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Jul 12, 2024
Merged
@marquiz marquiz mentioned this pull request Dec 12, 2024
Open
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marquiz marquiz marquiz approved these changes

@adrianchiris adrianchiris Awaiting requested review from adrianchiris

@jjacobelli jjacobelli Awaiting requested review from jjacobelli

Assignees

@marquiz marquiz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Swap misidentified due to trailing newline in file
4 participants
@TessaIO @marquiz @k8s-ci-robot @k8s-infra-cherrypick-robot