Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature-gates: mark NodeFeatureAPI as GA #1778

Merged
merged 1 commit into from
Jul 16, 2024
Merged

feature-gates: mark NodeFeatureAPI as GA #1778

merged 1 commit into from
Jul 16, 2024

Conversation

marquiz
Copy link
Contributor

@marquiz marquiz commented Jul 10, 2024

The feature gate is locked to true. That is, it is not possible to revert back to the gPRC-based communication which makes the gRPC API ready for removal.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 10, 2024
@netlify Netlify
Copy link

netlify bot commented Jul 10, 2024 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-nfd ready!

Name Link
🔨 Latest commit 25e827a
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-nfd/deploys/66965173bcc8ca000893fd52
😎 Deploy Preview https://deploy-preview-1778--kubernetes-sigs-nfd.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@marquiz
Copy link
Contributor Author

marquiz commented Jul 10, 2024

Refs #1546, let's wait a bit for comments there

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 10, 2024
@ArangoGutierrez
Copy link
Contributor

/milestone v0.17

@k8s-ci-robot k8s-ci-robot added this to the v0.17 milestone Jul 10, 2024
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 10, 2024
@marquiz marquiz mentioned this pull request Jul 10, 2024
Closed
10 tasks
ArangoGutierrez
ArangoGutierrez approved these changes Jul 11, 2024
View reviewed changes
Copy link
Contributor

@ArangoGutierrez ArangoGutierrez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 11, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 8e035ae3e41bea562edffe78e3dbe91f165b8768

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 12, 2024
@marquiz marquiz force-pushed the devel/nf-api-ga branch 2 times, most recently from 7daf1ea to 675684a Compare July 12, 2024 05:13
@marquiz
Copy link
Contributor Author

marquiz commented Jul 12, 2024

Rebased, more updates on the documentation. There are still some tidbits left in the docs but I was planning to address them separately (Helm, TLS, developer guide) to make reviews easier (i.e. avoid this becoming a mega-PR here). My general thinking that it makes for an easier (and a better) review I we do this in smaller pieces like now listed #1546.

@marquiz marquiz mentioned this pull request Jul 12, 2024
Merged
@PiotrProkop
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 15, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: f54a9e13c492fa1cfa883a763249baed423886f0

@marquiz
feature-gates: mark NodeFeatureAPI as GA
25e827a 
The feature gate is locked to true. That is, it is not possible to revert
back to the gPRC-based communication which makes the gRPC API ready for
removal.
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 16, 2024
@k8s-ci-robot k8s-ci-robot requested a review from PiotrProkop July 16, 2024 10:54
@marquiz
Copy link
Contributor Author

marquiz commented Jul 16, 2024

Rebased. No objections so far :)
/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 16, 2024
ArangoGutierrez
ArangoGutierrez approved these changes Jul 16, 2024
View reviewed changes
Copy link
Contributor

@ArangoGutierrez ArangoGutierrez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 16, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 0409d20d1f130f93e66d845cfb895b8275862202

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ArangoGutierrez, marquiz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [ArangoGutierrez,marquiz]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit e30cf85 into kubernetes-sigs:master Jul 16, 2024
12 checks passed
@marquiz marquiz deleted the devel/nf-api-ga branch July 16, 2024 16:17
@marquiz marquiz mentioned this pull request Dec 12, 2024
Open
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArangoGutierrez ArangoGutierrez ArangoGutierrez approved these changes

@adrianchiris adrianchiris Awaiting requested review from adrianchiris

@PiotrProkop PiotrProkop Awaiting requested review from PiotrProkop

Assignees

@PiotrProkop PiotrProkop

@ArangoGutierrez ArangoGutierrez

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
v0.17
Development

Successfully merging this pull request may close these issues.
4 participants
@marquiz @ArangoGutierrez @k8s-ci-robot @PiotrProkop