-
Notifications
You must be signed in to change notification settings - Fork 247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: describe Kubernetes version compatibility in versions page #1764
docs: describe Kubernetes version compatibility in versions page #1764
Conversation
✅ Deploy Preview for kubernetes-sigs-nfd ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's check the 1.21 first
You're right. In practice we need v1.24 or later because our deployments (both Helm and kustomize) depend on gRPC container probes |
Bump the required Kubernetes version to v1.24. In practice this is the minimum Kubernetes version as our deployment (both kustomize and Helm) depend on the gRPC container probes feature of Kubernetes.
a1e1582
to
6515990
Compare
Updated (bumped minimum required version to v1.24). @ArangoGutierrez PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ArangoGutierrez, marquiz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
LGTM label has been added. Git tree hash: 6fba91da6df4efe050c964df4ae60c58112aa66c
|
/cherry-pick release-0.16 |
@marquiz: new pull request created: #1772 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Bump the required Kubernetes version to v1.24. In practice this is the
minimum Kubernetes version as our deployment (both kustomize and Helm)
depend on the gRPC container probes feature of Kubernetes.