Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: describe Kubernetes version compatibility in versions page #1764

Merged
merged 1 commit into from
Jul 8, 2024

Conversation

marquiz
Copy link
Contributor

@marquiz marquiz commented Jul 8, 2024

Bump the required Kubernetes version to v1.24. In practice this is the
minimum Kubernetes version as our deployment (both kustomize and Helm)
depend on the gRPC container probes feature of Kubernetes.

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 8, 2024
Copy link

netlify bot commented Jul 8, 2024

Deploy Preview for kubernetes-sigs-nfd ready!

Name Link
🔨 Latest commit 6515990
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-nfd/deploys/668bdbf78e4f790008fcf838
😎 Deploy Preview https://deploy-preview-1764--kubernetes-sigs-nfd.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@ArangoGutierrez ArangoGutierrez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's check the 1.21 first

@marquiz
Copy link
Contributor Author

marquiz commented Jul 8, 2024

let's check the 1.21 first

You're right. In practice we need v1.24 or later because our deployments (both Helm and kustomize) depend on gRPC container probes

Bump the required Kubernetes version to v1.24. In practice this is the
minimum Kubernetes version as our deployment (both kustomize and Helm)
depend on the gRPC container probes feature of Kubernetes.
@marquiz marquiz force-pushed the devel/docs-k8s-compat branch from a1e1582 to 6515990 Compare July 8, 2024 12:30
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 8, 2024
@marquiz
Copy link
Contributor Author

marquiz commented Jul 8, 2024

Updated (bumped minimum required version to v1.24). @ArangoGutierrez PTAL

Copy link
Contributor

@ArangoGutierrez ArangoGutierrez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 8, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ArangoGutierrez, marquiz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [ArangoGutierrez,marquiz]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 6fba91da6df4efe050c964df4ae60c58112aa66c

@k8s-ci-robot k8s-ci-robot merged commit 4dc9f83 into kubernetes-sigs:master Jul 8, 2024
8 checks passed
@marquiz marquiz deleted the devel/docs-k8s-compat branch July 8, 2024 13:58
@marquiz
Copy link
Contributor Author

marquiz commented Jul 9, 2024

/cherry-pick release-0.16

@k8s-infra-cherrypick-robot

@marquiz: new pull request created: #1772

In response to this:

/cherry-pick release-0.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@marquiz marquiz mentioned this pull request Dec 12, 2024
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants